An error occurred fetching the project authors.
- 06 Sep, 2017 3 commits
-
-
Annabel Dunstone Gray authored
-
Rubén Dávila authored
-
Alexander Keramidas authored
-
- 05 Sep, 2017 1 commit
-
-
Alexis Reigel authored
-
- 25 Aug, 2017 1 commit
-
-
Hiroyuki Sato authored
-
- 24 Aug, 2017 1 commit
-
-
Andrew Newdigate authored
-
- 18 Aug, 2017 1 commit
-
-
Michael Kozono authored
-
- 17 Aug, 2017 1 commit
-
-
Michael Kozono authored
-
- 10 Aug, 2017 1 commit
-
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
- 09 Aug, 2017 1 commit
-
-
Michael Kozono authored
-
- 07 Aug, 2017 1 commit
-
-
Yorick Peterse authored
The method User#projects_limit_left would run "personal_projects.count" but such a query is not memoized. As a result multiple calls to User#projects_limit_left would result in multiple COUNT(*) queries being executed. To work around this this commit adds User#personal_projects_count which simply memoizes the result of the COUNT(*) in an instance variable.
-
- 02 Aug, 2017 1 commit
-
-
Robert Speicher authored
-
- 27 Jul, 2017 5 commits
-
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 24 Jul, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 18 Jul, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 14 Jul, 2017 1 commit
-
-
Tiago Botelho authored
-
- 13 Jul, 2017 1 commit
-
-
Robin Bobbitt authored
When sign-in is disabled: - skip password expiration checks - prevent password reset requests - don’t show Password tab in User Settings - don’t allow login with username/password for Git over HTTP requests - render 404 on requests to Profiles::PasswordsController
-
- 12 Jul, 2017 1 commit
-
-
Nathan Neulinger authored
Add spec tests for encoding
-
- 11 Jul, 2017 1 commit
-
-
Paul Charlton authored
-
- 29 Jun, 2017 1 commit
-
-
Tiago Botelho authored
-
- 27 Jun, 2017 2 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
This allows to enable/disable a feature flag for a given user, or a given Flipper group (must be declared statically in the `flipper.rb` initializer beforehand). Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 23 Jun, 2017 4 commits
-
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
Toon Claes authored
In CE only the admin has access to all private groups & projects. In EE also an auditor can have full private access. To overcome merge conflicts, or accidental incorrect access rights, abstract this out in `User#full_private_access?`. `User#admin?` now only should be used for admin-only features. For private access-related features `User#full_private_access?` should be used. Backported from gitlab-org/gitlab-ee!2199
-
- 21 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 19 Jun, 2017 1 commit
-
-
Tiago Botelho authored
-
- 16 Jun, 2017 1 commit
-
-
Tiago Botelho authored
-
- 14 Jun, 2017 1 commit
-
-
Robert Speicher authored
-
- 08 Jun, 2017 2 commits
-
-
DJ Mountney authored
Ran: - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch - git checkout -b 9-2-5-security-patch origin/v9.2.2 - git apply patchfile.patch - git commit - [Got the sha ref for the commit] - git checkout -b upstream-9-2-security master - git cherry-pick <SHA of the patchfile commit> - [Resolved conflicts] - git cherry-pick --continue
-
DJ Mountney authored
Ran: - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch - git checkout -b 9-2-5-security-patch origin/v9.2.2 - git apply patchfile.patch - git commit - [Got the sha ref for the commit] - git checkout -b upstream-9-2-security master - git cherry-pick <SHA of the patchfile commit> - [Resolved conflicts] - git cherry-pick --continue
-
- 06 Jun, 2017 1 commit
-
-
- 02 Jun, 2017 1 commit
-
-
Nick Thomas authored
-
- 30 May, 2017 1 commit
-
-
Toon Claes authored
To avoid the use of slow queries, remove some deprecated methods and encourage the use of ProjectFinder to find projects.
-
- 24 May, 2017 1 commit
-
-
Alexis Reigel authored
we do this on attribute read since migrating all existing users is not a feasible solution.
-