An error occurred fetching the project authors.
  1. 06 Sep, 2017 3 commits
  2. 05 Sep, 2017 1 commit
  3. 25 Aug, 2017 1 commit
  4. 24 Aug, 2017 1 commit
  5. 18 Aug, 2017 1 commit
  6. 17 Aug, 2017 1 commit
  7. 10 Aug, 2017 1 commit
    • Yorick Peterse's avatar
      Migrate events into a new format · 0395c471
      Yorick Peterse authored
      This commit migrates events data in such a way that push events are
      stored much more efficiently. This is done by creating a shadow table
      called "events_for_migration", and a table called "push_event_payloads"
      which is used for storing push data of push events. The background
      migration in this commit will copy events from the "events" table into
      the "events_for_migration" table, push events in will also have a row
      created in "push_event_payloads".
      
      This approach allows us to reclaim space in the next release by simply
      swapping the "events" and "events_for_migration" tables, then dropping
      the old events (now "events_for_migration") table.
      
      The new table structure is also optimised for storage space, and does
      not include the unused "title" column nor the "data" column (since this
      data is moved to "push_event_payloads").
      
      == Newly Created Events
      
      Newly created events are inserted into both "events" and
      "events_for_migration", both using the exact same primary key value. The
      table "push_event_payloads" in turn has a foreign key to the _shadow_
      table. This removes the need for recreating and validating the foreign
      key after swapping the tables. Since the shadow table also has a foreign
      key to "projects.id" we also don't have to worry about orphaned rows.
      
      This approach however does require some additional storage as we're
      duplicating a portion of the events data for at least 1 release. The
      exact amount is hard to estimate, but for GitLab.com this is expected to
      be between 10 and 20 GB at most. The background migration in this commit
      deliberately does _not_ update the "events" table as doing so would put
      a lot of pressure on PostgreSQL's auto vacuuming system.
      
      == Supporting Both Old And New Events
      
      Application code has also been adjusted to support push events using
      both the old and new data formats. This is done by creating a PushEvent
      class which extends the regular Event class. Using Rails' Single Table
      Inheritance system we can ensure the right class is used for the right
      data, which in this case is based on the value of `events.action`. To
      support displaying old and new data at the same time the PushEvent class
      re-defines a few methods of the Event class, falling back to their
      original implementations for push events in the old format.
      
      Once all existing events have been migrated the various push event
      related methods can be removed from the Event model, and the calls to
      `super` can be removed from the methods in the PushEvent model.
      
      The UI and event atom feed have also been slightly changed to better
      handle this new setup, fortunately only a few changes were necessary to
      make this work.
      
      == API Changes
      
      The API only displays push data of events in the new format. Supporting
      both formats in the API is a bit more difficult compared to the UI.
      Since the old push data was not really well documented (apart from one
      example that used an incorrect "action" nmae) I decided that supporting
      both was not worth the effort, especially since events will be migrated
      in a few days _and_ new events are created in the correct format.
      0395c471
  8. 09 Aug, 2017 1 commit
  9. 07 Aug, 2017 1 commit
    • Yorick Peterse's avatar
      Memoize a user's personal projects count · ab738645
      Yorick Peterse authored
      The method User#projects_limit_left would run "personal_projects.count"
      but such a query is not memoized. As a result multiple calls to
      User#projects_limit_left would result in multiple COUNT(*) queries being
      executed.
      
      To work around this this commit adds User#personal_projects_count which
      simply memoizes the result of the COUNT(*) in an instance variable.
      ab738645
  10. 02 Aug, 2017 1 commit
  11. 27 Jul, 2017 5 commits
  12. 24 Jul, 2017 1 commit
  13. 18 Jul, 2017 1 commit
  14. 14 Jul, 2017 1 commit
  15. 13 Jul, 2017 1 commit
    • Robin Bobbitt's avatar
      Fixes needed when GitLab sign-in is not enabled · 672a68d3
      Robin Bobbitt authored
      When sign-in is disabled:
       - skip password expiration checks
       - prevent password reset requests
       - don’t show Password tab in User Settings
       - don’t allow login with username/password for Git over HTTP requests
       - render 404 on requests to Profiles::PasswordsController
      672a68d3
  16. 12 Jul, 2017 1 commit
  17. 11 Jul, 2017 1 commit
  18. 29 Jun, 2017 1 commit
  19. 27 Jun, 2017 2 commits
  20. 23 Jun, 2017 4 commits
  21. 21 Jun, 2017 1 commit
  22. 19 Jun, 2017 1 commit
  23. 16 Jun, 2017 1 commit
  24. 14 Jun, 2017 1 commit
  25. 08 Jun, 2017 2 commits
    • DJ Mountney's avatar
      Bring in security changes from the 9.2.5 release · 565ead61
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
      565ead61
    • DJ Mountney's avatar
      Bring in security changes from the 9.2.5 release · 1d1363e2
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
      1d1363e2
  26. 06 Jun, 2017 1 commit
  27. 02 Jun, 2017 1 commit
  28. 30 May, 2017 1 commit
    • Toon Claes's avatar
      Remove some deprecated methods · 1e5506d0
      Toon Claes authored
      To avoid the use of slow queries, remove some deprecated methods and encourage
      the use of ProjectFinder to find projects.
      1e5506d0
  29. 24 May, 2017 1 commit