- 08 Jun, 2016 16 commits
-
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
This was not a clear cut n+1 query, given that if you're directly subscribed to all issues that the API is returning you never really need to check for the notes. However, if you're subscribed to _all_ of them, then for each issuable you need to go once to `notes`, and once to `users` (for the authors). By preemtively loading notes and authors, at worst you have 1 extra query, and at best you saved 2n extra queries. We also took advantage of this preloading of notes when counting user notes.
-
Alejandro Rodríguez authored
`notes_with_associations` are used for `participant` declarations, but `Participable` only really cares about the target entity project, and not the participants projects. `notes_with_associations` are also used in `Commit::has_been_reverted?` which employs the reference extractor of the commit, so no references to the notes projects are made there (`Mentionable::all_references` cares only about the `author` and other `attr_mentionable`). A paralel situation occurs on `Issue::referenced_merge_requests`.
-
Rémy Coutable authored
Add fog-azure to supported backup list !4396 left out Azure by accident. See merge request !4444
-
Rémy Coutable authored
Dismantling Grack::Auth part 1: Git HTTP clients Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/14501 This does not completely get rid of Grack::Auth yet because Git LFS support is 'behind' it and I would like to not make this MR bigger than needed. - changed tests to make HTTP requests instead of calling Rack apps - added missing test cases for Git HTTP authentication - moved Git HTTP requests into a 'normal' Rails controller See merge request !3361
-
Rémy Coutable authored
Fix endless redirections when accessing user OAuth applications when they are disabled ## What does this MR do? This MR fixes a bug where the browser would be redirect endlessly when attempting to access the user's OAuth applications when an admin has disabled this system-wide setting. ## Are there points in the code the reviewer needs to double check? I assume disabling the nav button is better than showing a page that says, "OAuth applications are disabled by the admin." ## Why was this MR needed? Lots of users were confused when they hit endless redirect errors. ## What are the relevant issue numbers? #14770 See merge request !4525
-
Stan Hu authored
Fix markdown_spec to not use `before(:all)` in order to properly cleanup database after testing See merge request !4515
-
Stan Hu authored
Also hides the "Applications" nav button if OAuth applications are disabled by the admin. Closes #14770
-
Douwe Maan authored
Add a test for User#ci_authorized_runners ## What does this MR do? Add a test for User#ci_authorized_runners ## Are there points in the code the reviewer needs to double check? Should we add `Project#add_user` so that it's similar to `Group#add_user`? ## Why was this MR needed? I am going to make some changes to this method for !4093, but I couldn't find a corresponding test so I want to add it in case I would break anything. ## What are the relevant issue numbers? This is a test for current behaviour, before implementing #3407 See merge request !4404
-
Douwe Maan authored
Check if GitHub rate limite API was reached before update Webhooks ## What does this MR do? Checks if the job needs to sleep, and wait for the rate limit to be reseted before update each Webhook. ## Are there points in the code the reviewer needs to double check? No. ## Why was this MR needed? The import process can fail if the API rate limit was reached during the import process. ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/17498 ## Screenshots (if relevant) Not relevant. See merge request !4509
-
Kamil Trzciński authored
Enable Knapsack only in CI environment Fixes running tests locally. Enables Knapsack only in CI environment. cc @grzesiek See merge request !4528
-
Kamil Trzcinski authored
-
Jacob Vosmaer authored
-
-
Jacob Schatz authored
Add flexbox to project header ## What does this MR do? Adds flexbox to project header to keep components vertically centered regardless of description presence/length ## What are the relevant issue numbers? Closes #18080 ## Screenshots (if relevant)   See merge request !4417
-
Jacob Schatz authored
Change color of canceled ci text to gray ## What does this MR do? Change text color of Canceled builds from `$gl-danger` to `$gl-gray` ## What are the relevant issue numbers? Closes #18074 ## Screenshots (if relevant) <img src="/uploads/f2ac59c5081c31cfb34bdc0470e31384/Screen_Shot_2016-06-01_at_10.38.17_AM.png" width="600px"> See merge request !4412
-
- 07 Jun, 2016 24 commits
-
-
Robert Speicher authored
Bump recaptcha gem to 3.0.0 to remove deprecated stoken support Google deprecated the use of stoken in its reCAPTCHA, so this gem is necessary to make things work again. Closes #18210 See merge request !4484
-
Stan Hu authored
-
Robert Speicher authored
Optimise email CSS for speed with Premailer Speed up emails-on-push by removing all descendant selectors from the CSS they use, which can make the CSS inlining much more efficient in certain cases. See: https://gitlab.com/gitlab-org/gitlab-ee/issues/490 See merge request !4511
-
Robert Speicher authored
Bump nokogiri to 1.6.8 Number of important security and bug fixes. See: https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md#168--2016-06-06 See merge request !4500
-
Stan Hu authored
Closes #18210
-
Stan Hu authored
Load knapsack in Rakefile only when is bundled Fixes `production` builds: https://dev.gitlab.org/gitlab/omnibus-gitlab/builds/85407 cc @marin See merge request !4514
-
Jacob Schatz authored
Notifications dropdown on project page now has descriptions ## What does this MR do? Adds descriptions to the notification settings dropdown on project pages. Also changed the order of them to make more sense. ## What are the relevant issue numbers? Part of #12758 ## Screenshots (if relevant)  See merge request !4374
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Stan Hu authored
Add License Finder information to contribution acceptance criteria. To make it clear what should be done when the license finder test fails. cc: @stanhu See merge request !4512
-
Connor Shea authored
-
Stan Hu authored
-
Jacob Schatz authored
Sub navigation ## What does this MR do? Styles sub nav cc @dzaporozhets @skyruler @jschatz1 ## What are the relevant issue numbers? #18058 and #17983 ## Screenshots (if relevant)   See merge request !4468
-
Jacob Schatz authored
Implement compact side nav ## What does this MR do? Implements new compact nav design Note- new navbar icons are in a separate MR (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4268) ## What are the relevant issue numbers? Closes #18013 ## Screenshots (if relevant)   cc @dzaporozhets See merge request !4447
-
Yorick Peterse authored
Instrument `RepositoryCheck::SingleRepositoryWorker` manually See merge request !4446
-
Alejandro Rodríguez authored
This worker is called manually by `RepositoryCheck::BatchWorker` meaning it's not tracked automatically by the Sidekiq middleware.
-
Rémy Coutable authored
Add new GitLab CI configuration facade class ## What does this MR do? This MR is a first iteration of major CI configuration refactoring. See #17139 and #15060 for more details. ## What are the relevant issue numbers? Closes #17139 See merge request !4462
-
Stan Hu authored
Number of important security and bug fixes. See: https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md#168--2016-06-06
-
Jacob Schatz authored
Ability to prioritize labels Closes #14189 See merge request !4009
-
Kamil Trzciński authored
Fix knapsack for master It were mistakenly to invoke `rspec` where it should invoke `spinach`. See merge request !4510
-
Annabel Dunstone authored
-
Lin Jen-Shin authored
Feedback from: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12301563
-
-
-
