An error occurred fetching the project authors.
- 15 Dec, 2017 1 commit
-
-
Marcia Ramos authored
-
- 06 Dec, 2017 1 commit
-
-
Rémy Coutable authored
Add "Guidelines for implementing Enterprise Edition features" in CE development doc since the doc page is already there Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 05 Dec, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 16 Nov, 2017 1 commit
-
-
Eric Eastwood authored
-
- 15 Nov, 2017 1 commit
-
-
Eric Eastwood authored
-
- 07 Nov, 2017 1 commit
-
-
Yorick Peterse authored
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
- 01 Nov, 2017 1 commit
-
-
Achilleas Pipinellis authored
-
- 11 Oct, 2017 2 commits
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
-
- 09 Oct, 2017 1 commit
-
-
Achilleas Pipinellis authored
-
- 05 Oct, 2017 1 commit
-
-
James Ramsay authored
-
- 27 Sep, 2017 1 commit
-
-
Andrew Newdigate authored
-
- 12 Sep, 2017 1 commit
-
-
Robert Speicher authored
-
- 11 Sep, 2017 1 commit
-
-
Yorick Peterse authored
-
- 16 Aug, 2017 3 commits
-
-
Yorick Peterse authored
-
Yorick Peterse authored
-
Yorick Peterse authored
-
- 07 Jul, 2017 2 commits
-
-
Yorick Peterse authored
This module provides a class method called `each_batch` that can be used to iterate tables in batches in a more efficient way compared to Rails' `in_batches` method. This commit also includes a RuboCop cop to blacklist the use of `in_batches` in favour of this new method.
-
Yorick Peterse authored
This module provides a class method called `each_batch` that can be used to iterate tables in batches in a more efficient way compared to Rails' `in_batches` method. This commit also includes a RuboCop cop to blacklist the use of `in_batches` in favour of this new method.
-
- 29 Jun, 2017 1 commit
-
-
Yorick Peterse authored
These attributes are stored in binary in the database, but exposed as strings. This allows one to query/create data using plain SHA1 hashes as Strings, while storing them more efficiently as binary.
-
- 12 Jun, 2017 1 commit
-
-
Yorick Peterse authored
Background migrations can be used to perform long running data migrations without these blocking a deployment procedure. See MR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11854 for more information.
-
- 07 Jun, 2017 2 commits
-
-
Yorick Peterse authored
-
Yorick Peterse authored
Instead of using polymorphic associations a developer should use separate tables.
-
- 31 May, 2017 2 commits
-
-
Alejandro Rodríguez authored
-
Yorick Peterse authored
-
- 16 May, 2017 1 commit
-
-
Rubén Dávila Santos authored
-
- 08 May, 2017 1 commit
-
-
Yorick Peterse authored
[ci skip]
-
- 05 May, 2017 1 commit
-
-
Balasankar C authored
-
- 25 Apr, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 29 Mar, 2017 1 commit
-
-
Achilleas Pipinellis authored
-
- 22 Mar, 2017 1 commit
-
-
Filipa Lacerda authored
-
- 27 Jan, 2017 1 commit
-
-
Adam Niedzielski authored
-
- 17 Nov, 2016 2 commits
-
-
Victor Wu authored
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 12 Nov, 2016 1 commit
-
-
Achilleas Pipinellis authored
[ci skip]
-
- 10 Nov, 2016 1 commit
-
-
awhildy authored
Block out pages needed for ux_guide Add resources stub to ux_guide home Fill out principles and basics Add TOC to basics Move all of UI guide to new UX guide structure Add first level structure on ux-guide pages Add more details to buttons Add button images. Update link on development Renamed surfaces to templates. Add tooltip details Update typography and icons on Basics page Add images for color. First draft of voice and tone Delete findings page Refine pages. Fill out Surfaces pages Clean up layout on basics, surfaces, features. Add anchorlinks and counts to components Fill out components page Add item title and system info block Fill out Features page Switch tooltip placement image
-
- 31 Oct, 2016 2 commits
-
-
Robert Speicher authored
-
Yorick Peterse authored
These are regular Rails migrations that are executed by default. A user can opt-out of these migrations by setting an environment variable during the deployment process. Fixes gitlab-org/gitlab-ce#22133
-
- 21 Oct, 2016 1 commit
-
-
Yorick Peterse authored
Dumping too many jobs in the same queue (e.g. the "default" queue) is a dangerous setup. Jobs that take a long time to process can effectively block any other work from being performed given there are enough of these jobs. Furthermore it becomes harder to monitor the jobs as a single queue could contain jobs for different workers. In such a setup the only reliable way of getting counts per job is to iterate over all jobs in a queue, which is a rather time consuming process. By using separate queues for various workers we have better control over throughput, we can add weight to queues, and we can monitor queues better. Some workers still use the same queue whenever their work is related. For example, the various CI pipeline workers use the same "pipeline" queue. This commit includes a Rails migration that moves Sidekiq jobs from the old queues to the new ones. This migration also takes care of doing the inverse if ever needed. This does require downtime as otherwise new jobs could be scheduled in the old queues after this migration completes. This commit also includes an RSpec test that blacklists the use of the "default" queue and ensures cron workers use the "cronjob" queue. Fixes gitlab-org/gitlab-ce#23370
-
- 13 Oct, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-