- Change double quotes to single quotes.
- Why is `OmniAuth.config.full_host` being reassigned in the integration test?
- Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
- Other minor changes

- The test for `rake gitlab:env:info` executed the rake task, which mutated the
  list of omniauth providers, breaking subsequent tests relying on this list.

- I've changed the rake task to duplicate the providers list before modifying it.

- I tried to get this to work by stubbing out portions of the config within the
  test. This didn't work as expected because Devise/Omniauth loaded before the
  stub could run, and the stubbed config was ignored.

- I attempted to fix this by reloading Devise/Omniauth after stubbing the
  config. This successfully got Devise to load the stubbed providers, but failed
  while trying to access a route such as `user_gitlab_omniauth_authorize_path`.

- I spent a while trying to figure this out (even trying
  `Rails.application.reload_routes!`), but nothing seemed to work.

- I settled for adding this config directly to `gitlab.yml` rather than go down
  this path any further.

- Added saml, authentiq, cas3, and auth0
- Crowd seems to be a special case that will be handled separately.

- There was previously a test for `saml` login in `login_spec`, but this didn't
  seem to be passing. A lot of things didn't seem right here, and I suspect that
  this test hasn't been running. I'll investigate this further.

- It took almost a whole working day to figure out this line:

    OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }

  As always, it's obvious in retrospect, but it took some digging to figure out
  tests were failing and returning 404s during the callback phase.

- Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook

- Pass a `remember_me` query parameter along with the initial OAuth request, and
  pick this parameter up during the omniauth callback from
  request.env['omniauth.params']`.

- For 2FA-based login, copy the `remember_me` param from `omniauth.params` to
  `params`, which the 2FA process will pick up.

- For non-2FA-based login, simply call the `remember_me` devise method to set
  the session cookie.

Fixed typo in gitlab_flow.md

See merge request !12561

Replaces 'dashboard/new-project.feature' spinach with rspec

See merge request !12550

Eagerly create a milestone that is used in a feature spec

Closes #34609

See merge request !12604

Fix curl example paths (missing the 'files' segment)

See merge request !12588

Use correct milestones for filtering on Group Issues

Closes #34116

See merge request !12374

Signed-off-by: Rémy Coutable <remy@rymai.me>

Remove unnecessary pull command from codeclimate job

See merge request !12583

Adjust readme repo width

See merge request !12585

Make clear that Go 1.8 is required since GitLab 9.2

Closes #34525

See merge request !12564

Fix performance bar specs

See merge request !12225

Merge branch '34097-issue-board-remove-from-board-button-when-viewing-an-issue-gives-js-error-and-fails' into 'master'

Resolve "Issue Board -> "Remove from board" button when viewing an issue gives js error and fails"

Closes #34097

See merge request !12430

Make issuable sidebar setSidebarHeight more efficient

See merge request !12252

Make entrypoint and command keys to be array of strings

See merge request !12536

Enable webpack code splitting

Closes #32989

See merge request !12032

Add issuable-list class to shared mr/issue lists to fix new responsive layout

See merge request !12591

Remove empty afterEach() from issue_show app_spec.js

See merge request !12577

Restore timeago translations in renderTimeago.

See merge request !12590

New navigation breadcrumbs

Closes #34029

See merge request !12346

Remove initTimeagoTimeout and let timeago.js update timeagos internally.

Closes #34340

See merge request !12468

Speed up issue counting for a project

Closes #33913

See merge request !12457

Automatically hide sidebar on smaller screens

See merge request !12538