- 26 Jul, 2019 11 commits
-
-
GitLab Release Tools Bot authored
[ci skip]
-
GitLab Release Tools Bot authored
Extract SanitizeNodeLink and apply to WikiLinkFilter See merge request gitlab/gitlabhq!3143
-
Kerri Miller authored
The SanitizationFilter was running before the WikiFilter. Since WikiFilter can modify links, we could see links that _should_ be stopped by SanatizationFilter being rendered on the page. I (kerrizor) had previously addressed the bug in: https://gitlab.com/gitlab-org/gitlab-ee/commit/7bc971915bbeadb950bb0e1f13510bf3038229a4 However, an additional exploit was discovered after that was merged. Working through the issue, we couldn't simply shuffle the order of filters, due to some implicit assumptions about the order of filters, so instead we've extracted the logic that sanitizes a Nokogiri-generated Node object, and applied it to the WikiLinkFilter as well. On moving filters around: Once we start moving around filters, we get cascading failures; fix one, another one crops up. Many of the existing filters in the WikiPipeline chain seem to assume that other filters have already done their work, and thus operate on a "transform anything that's left" basis; WikiFilter, for instance, assumes any link it finds in the markdown should be prepended with the wiki_base_path.. but if it does that, it also turns `href="@user"` into `href="/path/to/wiki/@user"`, which the UserReferenceFilter doesn't see as a user reference it needs to transform into a user profile link. This is true for all the reference filters in the WikiPipeline.
-
GitLab Release Tools Bot authored
Don't display badges when builds are restricted Closes #2864 See merge request gitlab/gitlabhq!3175
-
GitLab Release Tools Bot authored
Do not allow localhost url redirection in GitHub Integration See merge request gitlab/gitlabhq!3188
-
GitLab Release Tools Bot authored
Drop feature to take ownership of a trigger token Closes #2868 See merge request gitlab/gitlabhq!3198
-
GitLab Release Tools Bot authored
MR pipeline permissions Closes #2871 See merge request gitlab/gitlabhq!3204
-
GitLab Release Tools Bot authored
Server Side Request Forgery mitigation bypass Closes #2872 See merge request gitlab/gitlabhq!3205
-
GitLab Release Tools Bot authored
Queries for Upload should be scoped by model See merge request gitlab/gitlabhq!3229
-
GitLab Release Tools Bot authored
Do not show moved issue ids for user not authorized Closes #2878 See merge request gitlab/gitlabhq!3230
-
GitLab Release Tools Bot authored
Filter params in MR build service Closes #2879 See merge request gitlab/gitlabhq!3237
-
- 25 Jul, 2019 1 commit
-
-
GitLab Release Tools Bot authored
[ci skip]
-
- 24 Jul, 2019 28 commits
-
-
Douglas Barbosa Alexandre authored
Use a base class for Peek views See merge request gitlab-org/gitlab-ce!31108
-
Paul Slaughter authored
Resolve "Remove `pluralize` in favour of `n__`" Closes #63553 See merge request gitlab-org/gitlab-ce!30882
-
Ezekiel Kigbo authored
Replaced instance of the `pluralize` js function with `n__` to follow our development guide.
-
Rémy Coutable authored
Remove unused peek view code See merge request gitlab-org/gitlab-ce!31099
-
Nick Thomas authored
Remove feature flag for tablesample counts See merge request gitlab-org/gitlab-ce!31048
-
-
Clement Ho authored
Update tooltip values to meet design specs Closes gitlab-ui#264 See merge request gitlab-org/gitlab-ce!30981
-
Stan Hu authored
Introduce a `DetailedView` base class, which is inherited by the Gitaly, Redis, and Rugged views. This reduces code duplication.
-
Marcia Ramos authored
Followup edit of documentation See merge request gitlab-org/gitlab-ce!30986
-
Evan Read authored
-
Sean McGivern authored
Increase the Review App deploy command timeout to 15 minutes Closes #64998 See merge request gitlab-org/gitlab-ce!31061
-
Grzegorz Bizon authored
Remove OAuth GitHub CI/CD project code paths See merge request gitlab-org/gitlab-ce!30716
-
Mike Greiling authored
Add projectIds to CA service See merge request gitlab-org/gitlab-ce!30894
-
Brandon Labuschagne authored
-
Marcia Ramos authored
Fix some errors in Markdown files See merge request gitlab-org/gitlab-ce!30822
-
Evan Read authored
-
Marcia Ramos authored
Better information on blocking users Closes #61255 and #53748 See merge request gitlab-org/gitlab-ce!30767
-
Evan Read authored
-
Marcia Ramos authored
Improve the Auto DevOps topic a bit See merge request gitlab-org/gitlab-ce!30721
-
Evan Read authored
-
Marcia Ramos authored
Docs: Clean up headers in markdown See merge request gitlab-org/gitlab-ce!30597
-
Marcel Amirault authored
Some markdown headers needed tweaking to adhere to standards, including blank lines above and below, only one space after hash, first header should be h1, and only one h1 per doc
-
Marcia Ramos authored
Improve code quality documentation Closes #60725 See merge request gitlab-org/gitlab-ce!30545
-
Evan Read authored
-
Marcia Ramos authored
PerhAdd documentation for Design Management feature See merge request gitlab-org/gitlab-ce!30448
-
Marcia Ramos authored
Add Go test guidelines See merge request gitlab-org/gitlab-ce!29159
-
Steve Azzopardi authored
-
Marcia Ramos authored
Improve GitLab and Docker configuration docs Closes #31379 See merge request gitlab-org/gitlab-ce!30498
-