An error occurred fetching the project authors.
- 30 Apr, 2019 1 commit
-
-
Stan Hu authored
We've seen a significant performance penalty when using `BatchLoader#__replace_with!`. This defines methods on the batch loader that proxy to the 'real' object using send. The alternative is `method_missing`, which is slower. However, we've noticed that `method_missing` can be faster if: 1. The objects being loaded have a large interface. 2. We don't call too many methods on the loaded object. Avatar uploads meet both criteria above, so let's use the newly-released feature in https://github.com/exAspArk/batch-loader/pull/45. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903
-
- 19 Dec, 2018 1 commit
-
-
Stan Hu authored
In a merge request with many discussions, the avatar URL can be called thousands of times, inflicting a significant performance penalty especially when avatars are stored in object storage. To mitigate this problem, we can just cache the generated path any time it is requested. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55355
-
- 17 Nov, 2018 1 commit
-
-
Jasper Maes authored
-
- 04 Sep, 2018 1 commit
-
-
Stan Hu authored
Every time a column in the projects table is changed, the Avatarable concern would validate that the avatar file size was under 200K. This not only delays the database changes, but it also can lead to unrelated failures if the HTTP request fails for some reason. Closes #51053
-
- 07 Aug, 2018 2 commits
-
-
gfyoung authored
Partially addresses #47424.
-
Tim Zallmann authored
-
- 05 Jun, 2018 1 commit
-
-
Sean McGivern authored
This is tricky: the query was being run in `ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't just add batch loading there, because the `#upload=` method there would use the result immediately, making the batch only have one item. Instead, we can pre-emptively add an item to the batch whenever an avatarable object is initialized, and then reuse that batch item in `#retrieve_from_store!`. However, this also has problems: 1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`. 2. Some of that logic constructs a 'fake' model for the batch key. This should be fine, because of ActiveRecord's override of `#==`, but it relies on that staying the same.
-
- 23 Apr, 2018 1 commit
-
-
Micaël Bergeron authored
-
- 22 Mar, 2018 1 commit
-
-
Fabian Schneider authored
-
- 01 Mar, 2018 1 commit
-
-
Micaël Bergeron authored
-
- 28 Feb, 2018 2 commits
-
-
Kamil Trzciński authored
This reverts commit 54a575f1, reversing changes made to c63af942.
-
Sean McGivern authored
Move uploads to object storage Closes #4163 See merge request gitlab-org/gitlab-ee!3867
-
- 01 Feb, 2018 1 commit
-
-
Micaël Bergeron authored
-
- 09 Nov, 2017 1 commit
-
-
Douwe Maan authored
-
- 09 Oct, 2017 1 commit
-
-
Tim Zallmann authored
-
- 05 Oct, 2017 1 commit
-
-
Tim Zallmann authored
-
- 04 Oct, 2017 3 commits
-
-
Tim Zallmann authored
-
Tim Zallmann authored
Tests for these new helper methods
-
Tim Zallmann authored
-
- 10 May, 2017 1 commit
-
-
blackst0ne authored
-