1. 01 Mar, 2018 1 commit
    • Dylan Griffith's avatar
      Fix feature spec Clusters Applications (#17052) · ebac9c81
      Dylan Griffith authored
      We need to actually wait for the "Install" button to be enabled before clicking it otherwise we have a race condition where it sometimes works. Also change the `expect(page.find(...))` to `expect(page).to have_css` as this is prefered to avoid race conditions
      ebac9c81
  2. 28 Feb, 2018 1 commit
  3. 25 Feb, 2018 2 commits
  4. 23 Feb, 2018 2 commits
    • Filipa Lacerda's avatar
      Remove extra space from string · 636e2856
      Filipa Lacerda authored
      636e2856
    • Dylan Griffith's avatar
      Fix spec/features/projects/clusters/applications_spec.rb (#42643)> · f7693080
      Dylan Griffith authored
      Also remove the flakiness by using
      `expect(page).to have_css(..., exact_text: '')` instead of
      `expect(page.find(...).text).to eq('')` since the former will wait until
      the text has this value while the latter will only wait for the element
      to exist then test its text straight away which introduces a race
      condition if the element is already there with a previous text value.
      This test was failing locally most of the time because of this other
      way of asserting.
      f7693080
  5. 22 Feb, 2018 34 commits