An error occurred fetching the project authors.
  1. 16 May, 2018 3 commits
    • Jan Provaznik's avatar
      Fixed typo · 8c0166f2
      Jan Provaznik authored
      8c0166f2
    • Jan Provaznik's avatar
      Use find_in_batches instead of destroy_all · c81a37c1
      Jan Provaznik authored
      destroy_all loads all records at once
      c81a37c1
    • Jan Provaznik's avatar
      Delete remote uploads · 7da3b2cd
      Jan Provaznik authored
      ObjectStore uploader requires presence of associated `uploads` record
      when deleting the upload file (through the carrierwave's after_commit
      hook) because we keep info whether file is LOCAL or REMOTE in `upload`
      object.
      
      For this reason we can not destroy uploads as "dependent: :destroy" hook
      because these would be deleted too soon. Instead we rely on
      carrierwave's hook to destroy `uploads` in after_commit hook.
      
      But in before_destroy hook we still have to delete not-mounted uploads
      (which don't use carrierwave's destroy hook). This has to be done in
      before_Destroy instead of after_commit because `FileUpload` requires
      existence of model's object on destroy action.
      
      This is not ideal state of things, in a next step we should investigate
      how to unify model dependencies so we can use same workflow for all
      uploads.
      
      Related to #45425
      7da3b2cd