Merge pull request #310 from jstafford/reference-count-bugfix

add missing hiwire_decref, fixes issue #301

Merge pull request #310 from jstafford/reference-count-bugfix
add missing hiwire_decref, fixes issue #301
22be7eec · Michael Droettboom · GitHub · fc7d9404 · 1c780435 · 22be7eec
Commit 22be7eec authored Jan 28, 2019 by Michael Droettboom Committed by GitHub Jan 28, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 5 deletions

src/jsproxy.c src/jsproxy.c +7 -5

No files found.
--- a/src/jsproxy.c
+++ b/src/jsproxy.c
@@ -200,13 +200,15 @@ JsProxy_IterNext(PyObject* o)
  int iddone = hiwire_get_member_string(idresult, (int)"done");
  int done = hiwire_nonzero(iddone);
  hiwire_decref(iddone);
-  if (done) {
-    return NULL;
+
+  PyObject* pyvalue = NULL;
+  if (!done) {
+    int idvalue = hiwire_get_member_string(idresult, (int)"value");
+    pyvalue = js2python(idvalue);
+    hiwire_decref(idvalue);
  }

-  int idvalue = hiwire_get_member_string(idresult, (int)"value");
-  PyObject* pyvalue = js2python(idvalue);
-  hiwire_decref(idvalue);
+  hiwire_decref(idresult);
  return pyvalue;
 }