get_dimensions => get_shape

opcua/ua/uatypes.py

@@ -736,7 +736,7 @@ class Variant(FrozenClass):
         if self.VariantType is None:
             self.VariantType = self._guess_type(self.Value)
         if self.Dimensions is None and type(self.Value) in (list, tuple):
-            dims = get_dimensions(self.Value)
+            dims = get_shape(self.Value)
             if len(dims) > 1:
                 self.Dimensions = dims
 
@@ -832,7 +832,7 @@ def _split_list(l, n):
     return [l[i:i + n] for i in range(0, len(l), n)]
 
 
-def flatten_and_get_dimensions(mylist):
+def flatten_and_get_shape(mylist):
     dims = []
     dims.append(len(mylist))
     while isinstance(mylist[0], (list, tuple)):
@@ -853,7 +853,7 @@ def flatten(mylist):
     return mylist
 
 
-def get_dimensions(mylist):
+def get_shape(mylist):
     dims = []
     while isinstance(mylist, (list, tuple)):
         dims.append(len(mylist))

tests/tests.py

@@ -22,7 +22,7 @@ from opcua.ua import ObjectIds
 from opcua.ua import AttributeIds
 from opcua.ua import extensionobject_from_binary
 from opcua.ua import extensionobject_to_binary
-from opcua.ua.uatypes import flatten, get_dimensions, reshape
+from opcua.ua.uatypes import flatten, get_shape, reshape
 
 port_num1 = 48510
 port_num2 = 48530
@@ -115,7 +115,7 @@ class Unit(unittest.TestCase):
     def test_flatten(self):
         l = [[[1.0, 1.0, 1.0, 1.0], [1.0, 1.0, 1.0, 1.0], [1.0, 1.0, 1.0, 1.0]],[[1.0, 1.0, 1.0, 1.0], [1.0, 1.0, 1.0, 1.0], [1.0, 1.0, 1.0, 1.0]]]
         l2 = flatten(l)
-        dims = get_dimensions(l)
+        dims = get_shape(l)
         self.assertEqual(dims, [2, 3, 4])
         self.assertNotEqual(l, l2)
 
@@ -125,12 +125,12 @@ class Unit(unittest.TestCase):
 
         l = [[[], [], []], [[], [], []]]
         l2 = flatten(l)
-        dims = get_dimensions(l)
+        dims = get_shape(l)
         self.assertEqual(dims, [2, 3, 0])
 
         l = [1, 2, 3, 4]
         l2 = flatten(l)
-        dims = get_dimensions(l)
+        dims = get_shape(l)
         self.assertEqual(dims, [4])
         self.assertEqual(l, l2)