- 29 Oct, 2018 1 commit
-
-
Jérome Perrin authored
-
- 26 Oct, 2018 2 commits
-
-
Jérome Perrin authored
Default method seem to work just fine and is compatible with the recent improvements in erp5_hal_jon_style ( 09d00cae )
-
Vincent Pelletier authored
set.__iadd__ does not like non-set values, but the intent of this API is to allow just any iterable (producing strings) to be returned, so use the more tolerant set.update method instead.
-
- 25 Oct, 2018 18 commits
-
-
Xiaowu Zhang authored
-
Jérome Perrin authored
This is a mix of features to help time tracking and reporting with small unrelated bug fixes and improvements. To help time tracking we show the time on support request with hour:minutes everywhere and set a stop date automatically. We also add interaction so that "user doing" is automatically added to the support request so that we can see "who did" and make reports based on this. Bug fixes/unrelated features: * when project does not have supply lines, show all services members of the support request use. Also change to pass relative URL of services, usually we don't pass IDs, but relative URLs. This is a visible/breaking change, because it's now required to configure services use. Because it's also required in erp5_crm, I expect it would not break too much. * momentjs' related time was not refreshed, so they kept displaying "a few second ago" even hours later * don't set HTML source as post title * prevent double submit of comments in support request app. /reviewed-on nexedi/erp5!780
-
Vincent Pelletier authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Arnaud Fontaine authored
predecessor, successor and trade_phase ListBox fields didn't have their own fields and thus only the title was displayed (eg 'Ordered' for 'Manufacturing/Ordered').
-
Vincent Pelletier authored
This allows breaking a circular dependency of catalog on itself: to index a local role, catalog must tell whether it's granted to a group or to a user, which used to happen using a catalog lookup (via PAS API), preventing catalog from being rebuilt from scratch. With this change, ERP5Site_filterUserIdSet must be implemented when custom role columns are used (viewable_owner is not concerned by this change). If it is implemented in a way which does not rely on catalog, catalog become rebuildable from a lone ZODB, without double-indexation of users nor security_uid explosion. Nothing prevents relying on catalog (which mayu be desired for backward-compatibility purposes), but such script will not be provided by generic ERP5, as the impossibility of recreating catalog from ZODB is considered a bug, and introducing such script amounts to introducing this bug. Create ERP5Site_filterUserIdList in tests which add custom viewable_* columns.
-
Vincent Pelletier authored
Use Owner role to help filling user_set: owners must be users, never groups. Only look for users among group_ids when they are candidate for indexation into a catalog_role column. This should very significantly reduce the number of user lookups, even bringing it to zero on instance with default catalog setting of catalog_role_set = set(["viewable_owner"]) . Also, only look for users if there are candidates for lookup. Also, rename local variable to better describe its content. Also, use set.__iadd__ instead of set.update (shorter).
-
Vincent Pelletier authored
Test loop invariant outside of loop. Use clearer and more consistent variable names. Avoid iterating twice when once is enough, allowing removal of "local_role_dict" local and simplification of corresponding dict structure. Avoid creating new instances when the existing one can be mutated. Evaluate dict as boolean instead of constructing an empty dict to compare against. Avoid using %-operator just to concatenate strings (allows en-passant typechecking). Drop unused locals. Do not use a dict when a set would be sufficient.
-
Vincent Pelletier authored
So that it can be reused outside of group manager without having to duplicate the backward-compatibility order. Also, simplify code.
-
Vincent Pelletier authored
Move variable initialisations closer to where they are actually used. Do not initialise a variable which will always be initilised again before its first use. Reduce argument indentation. Drop unhelpful comments. User document may not be a Person instance, use a more neutral variable name. Avoid single-use locals. Take advantage of zLOG.LOG's "error=True" idiom to not have to pull exception information ourselves.
-
Vincent Pelletier authored
-
- 24 Oct, 2018 7 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
Speed up JSON calculation by dropping not needed info for rendering. Render a listfield to select the relation field listboxes on the 'relation_form' page template.
-
Romain Courteaud authored
This remove the requirement to add an action for every form.
-
Romain Courteaud authored
No need to keep many references on the gadget itself. Javascript can calculate the length of an array... Reduce not needed DOM modification. Stop writing in the DOM when changing the template value. This keeps the focus on the select.
-
Romain Courteaud authored
-
Romain Courteaud authored
Fixup bf57228a This reduces the number of logs.
-
Jérome Perrin authored
When editing components, this warning is displayed on the console: ``` Ambiguous name for method of Products.ERP5.Document.SQLMethod.SQLMethod: 'manage_main' != 'manage' ``` fix by adding the same `_setName` that the [parent class does](https://github.com/zopefoundation/Products.ZSQLMethods/blob/2.13/src/Products/ZSQLMethods/SQL.py#L143). While looking a this, I realized that clicking on the breadcrumb in the ZMI, any part of ![image](/uploads/5e42659d8124b7566fb09cc76958a345/image.png) would redirect to the ERP5 xhtml style view. /reviewed-on nexedi/erp5!782
-
- 23 Oct, 2018 5 commits
-
-
Jérome Perrin authored
setting a title was a mistake, because it will just be HTML content. No title at all is better.
-
Jérome Perrin authored
otherwise the test stays on "a few seconds ago" and this becomes "wrong information", unlike an absolute date with stays correct.
-
Jérome Perrin authored
Only services whose use is included in the preferred SR use are allowed when openning a support request. We still filter the services according to supply lines applicable for the selected project, but allow all SR services when project does not define supplies. Another user visible change is that test we no longer select a random service, it must be a user decision (eventhough one possible sophistication could be to select the service when there's only one). Update test accordingly. Also use relative URL for service, not just the service ID (this is API breaking change, but the javascript part should not have this cached)
-
Jérome Perrin authored
Also validate "RequireAssistant" service which was exported as draft
-
Vincent Pelletier authored
It is extremely slow for some reason on large BTreeFolders inside BTreeFolder2's has_key (even on warm caches). Using get instead is significantly faster. Found by chance, calling getAcquiredCategoryList on a random Person when person_module contains of the order of magnitude of a million documents.
-
- 22 Oct, 2018 7 commits
-
-
Romain Courteaud authored
Do the calculations while ERP5 renders the form in JSON
-
Romain Courteaud authored
-
Tristan Cavelier authored
Web Illustration was duplicated in erp5_officejs and erp5_dms before nexedi/erp5@c838767b. After being removed, update erp5_officejs will uninstall this portal type /reviewed-on nexedi/erp5!783
-
Georgios Dagkakis authored
we used to add this value because ```select``` without ```option``` (that happens in MultiListField only) is invalid on XHTML. But it was not at all required for other cases like MultiCheckboxField or RadioField. Also, ```select``` without ```option``` is no longer invalid on HTML5. Considering that showing dummy unselectable <option> is anyway meaningless for users, we drop it for all cases. /reviewed-on !777
-
Jérome Perrin authored
from the destination section of the project.
-
Jérome Perrin authored
So that we can track more accurately the duration of the ticket. The date is always set, erasing a date if it was set, for scenarios where we close, reopen and close again. For cases where we forgot to close and close later, we can always close and the change the date.
-
Jérome Perrin authored
-