- 08 Nov, 2001 4 commits
-
-
Barry Warsaw authored
decref the revision string, added to the module dict with the keys "__version__". Do the same with the PyCObject set to the dict's "CAPI" key. This fixes small leaks detected by Insure. Also, clean up the way the global TimeStamp static is handled on creation failure. We need to decref `s' whether or not TimeStamp was properly created or not. Also, at the end of the function, we do a PyErr_Occurred() check and throw a fatal error if true. This makes this module's init function more in line with other init functions in this package.
-
Barry Warsaw authored
decref the revision string, added to the module dict with the keys "__version__". This fixes a small leaks detected by Insure. Also, instead of returning from the init should the PyString_FromString() of "TimeStamp.error fail, we simply take precautions by XDECREF'ing it. Then at the end of the function, we do a PyErr_Occurred() check and throw a fatal error if true. This makes this module's init function more in line with other init functions in this package.
-
Jeremy Hylton authored
-
Barry Warsaw authored
module dictionary under the "__version__" key. Plugs a small memory leak caught by Insure.
-
- 07 Nov, 2001 2 commits
-
-
Jeremy Hylton authored
The previous checkin stopped using the per-connection trigger, but didn't stop creating it. (Dang.) Thanks to Shane for noticing.
-
Jim Fulton authored
based on: - transaction iteration/copy - scanning for transactions after bad data This should allow recovery of data when: - only data records are damaged and when - multiple parts of a file are damaged The interface has changed to not modify in place. Other features: - Progress indicator - Verbose output - optional packing - index creation
-
- 06 Nov, 2001 3 commits
-
-
Jeremy Hylton authored
-
Jeremy Hylton authored
DB.py: typo in comment cPickleCache.c: fix cache sweep logic cPersistence.c: small performance changes
-
Jeremy Hylton authored
-
- 02 Nov, 2001 4 commits
-
-
Jeremy Hylton authored
-
Jeremy Hylton authored
Not sure how this one got missed.
-
Jeremy Hylton authored
The trunk now has the same code ZEO 1.0b5 plus a few minor changes.
-
Barry Warsaw authored
acceptability of serials=None for the object-creation store() call. Note that _dostore() itself never exercises this condition because it coerces its own serial argument to ZERO (a.k.a. '\0'*8) when None is passed in.
-
- 31 Oct, 2001 1 commit
-
-
Jeremy Hylton authored
The Mapping_update() method iterated over a sequence of 2-tuples, but held an extra reference to the sequence. The sequence object was DECREFed on an error exit but not on the normal return. The fix reworks the control flow of the function to make the reference counting behavior a little clearer: - Test for call with no arguments and return immediately if so. - If the argument is a sequence, don't INCREF it. - If the argument passed isn't a sequence, call its items() method and store the result in the local variables seq and items. - On exit, do Py_XDECREF(items). This will do a decref only if a the second case above applied. Two other minor nits: - Make consistent use of spaces around = in assignments (as opposed to a fix of both) - Remove assignment from conditional expression.
-
- 29 Oct, 2001 3 commits
-
-
Jeremy Hylton authored
pack() uses a coarse-grain timer to decide which revisions to look at during a pack. The tests depend on a pack() called after a commit to see that committed transaction, but the implementation can't guarantee that it will. In particular, pack() converts its time argument to a TimeStamp by truncating to the nearest second. If a transaction T1 commits and pack is called (with the current time as its argument) during the same second, the pack() will not consider T1. This was causing intermittent, but frequent test failures on Windows. The fix is to add a small delay in the pack test cases to guarantee that pack(time.time()) will always see the last committed transaction.
-
Jeremy Hylton authored
If the packpos returned by the read_index() call is 4, return immediately. In this case, the very first transaction, which contains the root object, is after the pack time. This is a degenerate case, but it seems clearest to do nothing. This change eliminates an unexpected traceback in pack() that occurred frequently, but not every time, when testing on Windows. When read_index() returned 4, a seek() call in _redundant_pack() would fail with a bad argument. Add an assertion to _redundant_pack() because it should never be called with bogus arguments as a result of the other change.
-
Jeremy Hylton authored
Don't test for explicit end-of-line markers, since they vary across platforms. Instead, strip() the line read and test for the actual content.
-
- 26 Oct, 2001 3 commits
-
-
Jeremy Hylton authored
If a storage doesn't support T.U. and is old enough, you need to first check if it has a supportsTransactionalUndo attribute.
-
Jeremy Hylton authored
There are a few problems with Zope 2.3 that prevented the tests from succeeding. Since the 1.0 release must support Zope 2.3, we'll need to hack the various tests to work around them. Assuming releases after 1.0 don't need to work with 2.3: After the 1.0 final release, I'll tag both ZEO and ZODB trees and then undo all these silly changes. Problems: - no support for transactional undo or getSerial() - FileStorage commitVersion() and abortVersion() didn't check for bogus arguments
-
Jeremy Hylton authored
-
- 24 Oct, 2001 4 commits
-
-
Jeremy Hylton authored
This implementation is only faster for an object that is not modified in a version. For an object modified in a version, it should be about the same as the default getSerial() in BaseStorage.
-
Barry Warsaw authored
situation.
-
Jeremy Hylton authored
Didn't write a more interesting test in checkAbortVersion: # XXX Not sure I can write a test for getSerial() in the # presence of aborted versions, because FileStorage and # Berkeley storage give a different answer. I think Berkeley # is right and FS is wrong.
-
Jeremy Hylton authored
BaseStorage implements this in terms of modifiedInVersion() and load(). Other storages may (perhaps even should) implement it more efficiently.
-
- 22 Oct, 2001 4 commits
-
-
Andreas Jung authored
now a full success :-)
-
Jeremy Hylton authored
(Minor change to tb handling to avoid unnecessary binding to None for v and tb.)
-
Jeremy Hylton authored
Prevents memory leak for each _restore_index() call.
-
Jeremy Hylton authored
-
- 19 Oct, 2001 3 commits
-
-
Andreas Jung authored
exceptions (this error occured when trying to access an OOBTree with a string with non-ascii encoding e.g. latin1. In this case Python raises a Unicode exception that has not been caught and not propagated to the application.
-
Andreas Jung authored
-
Shane Hathaway authored
-
- 18 Oct, 2001 1 commit
-
-
Jeremy Hylton authored
Replace explicit equality tests in assert statements, which aren't executed when running python -O, when self.assertEquals(), which also has the side effect of producing better error messages when the test fails.
-
- 17 Oct, 2001 1 commit
-
-
Tres Seaver authored
o Known breakage as of 2001/10/17: - TAL test suite is very broken (TAL is currently suppressed in lib/python/.testinfo). - AccessControl tests don't run if run first; lib/python/.testinfo pushes them to the end of the queue, at which point they *do* run. Global side effects suck! - lib/python/BTrees/testBTreesUnicode.py: weird flakiness around comparison of ASCII and Unicode strings; breaks in different ways under Python 2.1 and 2.2. - lib/python/Products/PageTemplates/tests: three tests break due to security asserctions.
-
- 15 Oct, 2001 3 commits
-
-
Jeremy Hylton authored
-
Jeremy Hylton authored
-
Andreas Jung authored
strings as keys
-
- 10 Oct, 2001 2 commits
-
-
Jeremy Hylton authored
-
Jeremy Hylton authored
Add getLogFile() method that provides hook for SpreadLog subclass.
-
- 08 Oct, 2001 2 commits
-
-
Jeremy Hylton authored
-
Jeremy Hylton authored
-