accounting: keep "??? (value)" to display invalid bank account

The changes from ae15e7e1 (accounting: show the context when
showing invalid bank accounts, 2022-12-21) were a regression because
with the previous behaviour, by just looking at the transactions,
users could see with the ??? that something was wrong with the bank
account. After these changes they had to open the select element.

This restore somehow the previous behaviour by displaying the label
with ??? marker, but since we have the label, we display the
label (bank account reference) instead of the value (the relative URL)

bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountModule_getBankAccountItemList.py

@@ -70,12 +70,14 @@ bank_account_list = [brain.getObject() for brain in sorted(
 )]
 
 
-def getItemList(bank_account):
+def getItemList(bank_account, warning=False):
   reference = bank_account.getReference()
   title = bank_account.getTitle() or bank_account.getSourceFreeText() or bank_account.getSourceTitle()
   label = title
   if reference != title:
     label = '{} - {}'.format(reference, title)
+  if warning:
+    label = '??? ({})'.format(label)
   return (label, bank_account.getRelativeUrl())
 
 
@@ -98,6 +100,6 @@ if base_category is not None:
       translateString(
         'Invalid bank account from ${entity_title}',
         mapping={'entity_title': current_value.getParentTitle()}), None))
-    item_list.append(getItemList(current_value))
+    item_list.append(getItemList(current_value, warning=True))
 
 return item_list

bt5/erp5_accounting/TestTemplateItem/portal_components/test.erp5.testAccounting.py

@@ -4988,7 +4988,7 @@ class TestTransactions(AccountingTestCase):
       [
         ('', ''),
         ('Invalid bank account from Client 1', None),
-        ('client_1 bank account', client_1_bank_account.getRelativeUrl()),
+        ('??? (client_1 bank account)', client_1_bank_account.getRelativeUrl()),
       ],
     )
 
@@ -5013,7 +5013,7 @@ class TestTransactions(AccountingTestCase):
       [
         ('', ''),
         ('Invalid bank account from Client 1', None),
-        ('client_1 bank account', client_1_bank_account.getRelativeUrl()),
+        ('??? (client_1 bank account)', client_1_bank_account.getRelativeUrl()),
       ],
     )