Commits · f627727fec0accfe45f965791888643374e04979 · Ivan Tyagov / neoppod

24 Jun, 2009 18 commits

Reorder connection initialisation packets for master connection: · f627727f

Vincent Pelletier authored Jun 24, 2009

- first, asks which master is the primary
- then, when connected to the primary, request node identification
- then, ask explicitely for partition table and node information, to follow query/answer schema.
Details:
- Master:
 - Move handleAskPrimaryMaster, handleAskNodeInformation and handleAskPartitionTable implementations to base handler to factorise code
 - handleRequestNodeIdentification is not required any more in secondary mode, only handleAskPrimaryMaster
- Client:
 - Make bootstrap handler and master connection behave more similarly to on storage's equivalents
 - Remove PrimaryHandler (moved into PrimaryNotificationsHandler)
 - parse master node configured ip list just once, and register them to node manager just once (in app's __init__)


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@681 71dcc9de-d417-0410-9af5-da40c76e7ee4

f627727f

neoctl doest not accept a 'logfile' parameter. · 3a48be31

Grégory Wisniewski authored Jun 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@680 71dcc9de-d417-0410-9af5-da40c76e7ee4

3a48be31

iFix some tests. · d8fd8409

Grégory Wisniewski authored Jun 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@679 71dcc9de-d417-0410-9af5-da40c76e7ee4

d8fd8409

Remove outdated comment. · c768d431

Vincent Pelletier authored Jun 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@678 71dcc9de-d417-0410-9af5-da40c76e7ee4

c768d431

implement more in the shutdown method · 1081da6f

Aurel authored Jun 24, 2009

- wait for all transaction to finish
- ask all other nodes to shut down if cluster is shutting down


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@677 71dcc9de-d417-0410-9af5-da40c76e7ee4

1081da6f

add handler for notify node information message so that they can be · 1742c007

Aurel authored Jun 24, 2009

ignored if we are stopping all storage and master nodes


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@676 71dcc9de-d417-0410-9af5-da40c76e7ee4

1742c007

Delete the __init__.py in the root directory since it's not a python module and · 1b261542

Grégory Wisniewski authored Jun 24, 2009

thus don't need to be imported.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@675 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b261542

Fix test with decorators imports. · 10e3542e

Grégory Wisniewski authored Jun 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@674 71dcc9de-d417-0410-9af5-da40c76e7ee4

10e3542e

Fix some tests about accessors on partitions number, replicas and partition · a26e93f6
Grégory Wisniewski authored Jun 24, 2009
```
table ID.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@673 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a26e93f6

Fix accessor on next partition table ID. · 25c190e1

Grégory Wisniewski authored Jun 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@672 71dcc9de-d417-0410-9af5-da40c76e7ee4

25c190e1

Factory cluster name verification. Do not use the decorator previously commited · 6e9b9f15

Grégory Wisniewski authored Jun 24, 2009

since the 'name' handler parameter is not positional-fixed nor a keyword
argument.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@671 71dcc9de-d417-0410-9af5-da40c76e7ee4

6e9b9f15

Fix naming of _checkNodeType in some callers which used a temporary name. · c5d9d9a9
Vincent Pelletier authored Jun 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@670 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c5d9d9a9
Admin handler forward setClusterState packet to the primary master node. · 746ac978
Grégory Wisniewski authored Jun 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@669 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
746ac978
Add a log when receiving an unknown UUID as primary master UUID. · b21e7309
Vincent Pelletier authored Jun 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@668 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b21e7309
Move handler decorators to their own file to simplify imports. · d256c5b3
Grégory Wisniewski authored Jun 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@667 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d256c5b3

when asking master node to shutdown, answer with notify node · e27a2a69

Aurel authored Jun 24, 2009

information message to admin node


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@666 71dcc9de-d417-0410-9af5-da40c76e7ee4

e27a2a69

last partition id is no longer set on app object but it's get from · bf3b80b2

Aurel authored Jun 24, 2009

partition table


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@665 71dcc9de-d417-0410-9af5-da40c76e7ee4

bf3b80b2

Add 2 new packet types: ASK_NODE_INFORMATION and ANSWER_NODE_INFORMATION. · a3497ce2
Vincent Pelletier authored Jun 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@664 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a3497ce2

23 Jun, 2009 7 commits

Factorise struct.error exception handling with a decorator over decoding · 3774858d

Grégory Wisniewski authored Jun 23, 2009

functions. Factorise check of enum based values and string decoding.
Unify tuple unpacking by always using parenthesis.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@663 71dcc9de-d417-0410-9af5-da40c76e7ee4

3774858d

Add handler for cluster state packet in neoctl. · 193a31e1

Grégory Wisniewski authored Jun 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@662 71dcc9de-d417-0410-9af5-da40c76e7ee4

193a31e1

getNodeByUUID always return None on invalid UUID, even if one was inserted by · 08f200bb

Grégory Wisniewski authored Jun 23, 2009

mistake. Add an helper method on the event manager to retreive a connection from
an UUID.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@661 71dcc9de-d417-0410-9af5-da40c76e7ee4

08f200bb

Include what handler class is ignoring a packet, and switch the log level to · 86056d54

Grégory Wisniewski authored Jun 23, 2009

ERROR since we don't want any useless packets.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@660 71dcc9de-d417-0410-9af5-da40c76e7ee4

86056d54

Packet SET_CLUSTER_STATE and ANSWER_CLUSTER_STATE : · 0ce0731e

Grégory Wisniewski authored Jun 23, 2009

- Add handler method
- Fix encoding and decoding
- Add cluster state enumeration
Fix exception handling in newer packet decoders (no more except *: )


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@659 71dcc9de-d417-0410-9af5-da40c76e7ee4

0ce0731e

Fix bug and set the first PTID on the partition table when making it from · a52db4e6
Grégory Wisniewski authored Jun 23, 2009
```
scratch.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@658 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a52db4e6

add a shutdown handler for the primary master node which : · 33b3065a

Aurel authored Jun 23, 2009

- refuse any new connection
- refuse any new transaction



git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@657 71dcc9de-d417-0410-9af5-da40c76e7ee4

33b3065a

22 Jun, 2009 13 commits

Master use PartitionTable to store the number of partitions, replicas and the · 059c6d6c

Grégory Wisniewski authored Jun 22, 2009

current partition table ID. The next partition table ID is now computed by the
master's PartitionTable instance.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@655 71dcc9de-d417-0410-9af5-da40c76e7ee4

059c6d6c

Add accessors for number of replicas and partitions in PartitionTable. · 0e03e516
Grégory Wisniewski authored Jun 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@654 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0e03e516
Restore logfile parameter, deleted in commit #632, and removed unused variable. · 53b35627
Grégory Wisniewski authored Jun 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@653 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
53b35627
Use same log format for all NEO applications and define it in the root module. · b4feb441
Grégory Wisniewski authored Jun 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@652 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b4feb441

Implement the PENDING storage node state, they start in this state and switch · 773ec228

Grégory Wisniewski authored Jun 22, 2009

to RUNNING state when requested by the admin node. This feature can be disabled
by setting neo.master.ENABLE_PENDING_NODES to False.
The neoctl syntax is : neoctl add (all | UUID+)
and display UUIDs of added storage nodes.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@651 71dcc9de-d417-0410-9af5-da40c76e7ee4

773ec228

Raise when transaction information cannot be found rather than silently skipping to next TID. · 5d10815c
Vincent Pelletier authored Jun 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@650 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5d10815c

Improve code readability by removing some "continue"s. · efe97eca

Vincent Pelletier authored Jun 22, 2009

Tiny inner loop optimisation on list append.
Remvoe unneeded (obvious) comments.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@649 71dcc9de-d417-0410-9af5-da40c76e7ee4

efe97eca

Get connection from the cell (loop variant) rather from the node (loop... · 04001b76

Vincent Pelletier authored Jun 22, 2009

Get connection from the cell (loop variant) rather from the node (loop invariant, remain from a loop higher in the same method).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@648 71dcc9de-d417-0410-9af5-da40c76e7ee4

04001b76

Use an intermediate set() to remove duplicate tids (as we request data from... · 9a46bf02

Vincent Pelletier authored Jun 22, 2009

Use an intermediate set() to remove duplicate tids (as we request data from all storage nodes, the same tid wille be reported one time per node replicating it).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@647 71dcc9de-d417-0410-9af5-da40c76e7ee4

9a46bf02

Move loop exit condition to loop declaration instead of explicitely breaking an infinite loop. · ac603ef1
Vincent Pelletier authored Jun 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@646 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ac603ef1

Use itervalues instead of values. · 19ed5c8d

Vincent Pelletier authored Jun 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@645 71dcc9de-d417-0410-9af5-da40c76e7ee4

19ed5c8d

Tiny iner-loop optimisation. · 7093110c

Vincent Pelletier authored Jun 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@644 71dcc9de-d417-0410-9af5-da40c76e7ee4

7093110c

There is no need to call keys() on a dict to know its len. · 37935329
Vincent Pelletier authored Jun 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@643 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
37935329

19 Jun, 2009 2 commits

Make _initNodeConnection expect a node, not a cell (just as the name implies). · a18a5e01

Vincent Pelletier authored Jun 19, 2009

Add a getConnForCell method to ConnectionPool class.
Use getConnForCell instead of getConnForNode in each place where a Cell is placed instead of a node.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@642 71dcc9de-d417-0410-9af5-da40c76e7ee4

a18a5e01

Node class (and inheriting classes) have a getState, getNodeState doens't exist. · 0f1164d9
Vincent Pelletier authored Jun 19, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@641 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0f1164d9