- 26 Jul, 2019 1 commit
-
-
Vincent Pelletier authored
-
- 25 Jul, 2019 4 commits
-
-
Vincent Pelletier authored
This property is only conditionally set, which causes distracting error when something goes wrong. If we really want to check that the expected code path was followed there has to be a better check and a more debugging- friendly error than an AttributeError.
-
Vincent Pelletier authored
While such activity parameter combination does not make sense, it is technically possible to spawn activities with a group_id set but without a grouping_method_id. The consequence is zombie activities: they never fail, do not prevent other activities from being executed, but and are permanently run on the node which reserved more than one because: - all but one activity is in MESSAGE_NOT_EXECUTED state, forcing an abort - finalizeMessageExecution does not understand that MESSAGE_NOT_EXECUTED activities may not have failed, and itself fail while trying to detect the failure type (ConflictError vs. others), failing to free & postpone the activity, in turn failing to bring it to eventually permanent failure state. Make those conditions consistent, and use tuple-unpacking to detect any future inconsistency much earlier, simplifying debugging.
-
Vincent Pelletier authored
group_method_id column is declared "NOT NULL", so it can only be None if getProcessableMessageList could not find any activity, in which case this code is not executed ("if message_list" is false). This simplifies two "if" statements.
-
Vincent Pelletier authored
-
- 23 Jul, 2019 1 commit
-
-
Sebastien Robin authored
-
- 22 Jul, 2019 2 commits
-
-
Romain Courteaud authored
So called "click-click" element.
-
Ivan Tyagov authored
What happens is that in same script (line 907) we want to calculateHateos for restricted case without passing (I consider explict decision) the response. What happens is that script will try to redirect to login form using non existing response parameter. So fix is redirect ONLY if we do pass response. This allows a Web Site to work with Anonymous accessible content. @romain and / or @rporchetto please feel free to contact me so I show my use case with a real example. /reviewed-on nexedi/erp5!905
-
- 19 Jul, 2019 1 commit
-
-
Yusei Tahara authored
[erp5_trade] Fix Base_viewTradeFieldLibrary/my_view_mode_price to support lines with variations(erp5_advanced_trade).
-
- 18 Jul, 2019 5 commits
-
-
Arnaud Fontaine authored
-
Yusei Tahara authored
-
Yusei Tahara authored
-
Yusei Tahara authored
To use variation is still too complex.
-
Arnaud Fontaine authored
-
- 17 Jul, 2019 9 commits
-
-
Yusei Tahara authored
MatrixBox is often used for price tables or code tables. So it is always useful for end users to display its contents.
-
Romain Courteaud authored
-
Romain Courteaud authored
Make it available for ERP5JS
-
Romain Courteaud authored
Store a new Selection everytime a Listbox content is calculated. This will allow actions checking the selection params to get expected results. Propagate selection_name in dialog if the dialog doesn't contain a listbox itself.
-
Romain Courteaud authored
-
Romain Courteaud authored
erp5 jio gadget: follow jio 3.38.1 changes
-
Romain Courteaud authored
Ensure that if the web site policy is just set to Must-Revalidate, all documents are updated. It forces HTTP Cache middleware to refresh their contents.
-
Romain Courteaud authored
See nexedi/erp5@f402de4e
-
Nicolas Wavrant authored
Because the number of objects to be retrieved can be too big, or because the query can be complex (depending on the definition of the domain), and because searchAndActivate add a sort on uid (even if it's a primary key, this sort is amplified by the 2 previous reasons), searchAndActivate should be activated to avoid timeouts for the user
-
- 15 Jul, 2019 2 commits
-
-
Arnaud Fontaine authored
erp5_simulation_fast_input: Solve Divergences dialog: Display all divergences in a single ListBox page. This dialog and its JS gadget does not handle multiple pages ListBox (because gadget_solve_divergence_dialog.js assumes that the view is the last part of the URL) and this is not actually needed (customer seldom goes over the previous limit to 20 anyway). How to reproduce: 1. Create >20 divergences (20 lines per page used to be displayed). 2. Go to Solve Divergences dialog: => gadget_solve_divergence_dialog.js: -> location.pathname == /erp5/purchase_order_module/42/Delivery_solveDivergenceAction. -> basedir=/erp5/purchase_order_module/42. => /erp5/purchase_order_module/42/Delivery_getSolveDivergenceDialogParameterFormBox XHR'ed: OK. 3. Go to any other ListBox page: => gadget_solve_divergence_dialog.js: -> location.pathname == /erp5/purchase_order_module/42. -> basedir=/erp5/purchase_order_module. =>/erp5/purchase_order_module/Delivery_getSolveDivergenceDialogParameterFormBox XHR'ed: NOK: [...] Module script, line 4, in Delivery_getSolveDivergenceDialogParameterFormBox - <PythonScript at /erp5/Delivery_getSolveDivergenceDialogParameterFormBox used for /erp5/purchase_order_module> - Line 4 solver_process = context.getSolverValueList()[-1] AttributeError: getSolverValueList
-
Arnaud Fontaine authored
erp5_simulation_fast_input: Solve Divergences dialog: Handle error when XHR'ing Solver configuration fails. When user clicks on the radio button to Accept Decision for example, Delivery_getSolveDivergenceDialogParameterFormBox is called (XHR) and when it failed, the 'Solve Divergences' button was disappearing and nothing was displayed to end-user.
-
- 10 Jul, 2019 1 commit
-
-
Arnaud Fontaine authored
* Not updated for many years (CodeMirror has since replaced it). * There are now 2 other better source code editors (CodeMirror and Monaco).
-
- 09 Jul, 2019 1 commit
-
-
Valentin Benozillo authored
-
- 08 Jul, 2019 2 commits
-
-
Romain Courteaud authored
Base domain .getRelativeUrl method does not include portal_domains. See https://lab.nexedi.com/nexedi/erp5/blob/c3f0585cc1ddb888d356b3395b947b90cb188356/product/ERP5/Document/Domain.py#L91
-
Romain Courteaud authored
-
- 05 Jul, 2019 2 commits
-
-
Romain Courteaud authored
See 88f24700 and 796c3520
-
Nicolas Wavrant authored
-
- 04 Jul, 2019 9 commits
-
-
Valentin Benozillo authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Clone Base_doAction to keep the logic identical. Reuse Folder_create directly to reduce difference from xhtml_style. Side effect: the status message is modified from 'Document created.' to 'Object created.'
-
Romain Courteaud authored
-
Roque authored
-
Jérome Perrin authored
This works only for medusa, using the same approach as CMFCore's CookieCrumbler Also increase test coverage of google/facebook plugins. /reviewed-on nexedi/erp5!901
-
Jérome Perrin authored
What I'm trying to prevent, is that when we have a document with leading/trailing space ![image](/uploads/8a00a1019cdcb5d76bd589917548a515/image.png) and it's set in a relation ![image](/uploads/925aa9895c7d15f3ef9f3bdc9926d7fd/image.png) just clicking save will complain that document is not found ![image](/uploads/a559eea23fc8ba0df19c23dfcda26138/image.png) this is because validator have stripped whitespace and search for `"leading and trailing space"` - and find nothing (unless title is a keyword key, but that's another story ) /reviewed-on !897
-
Sebastien Robin authored
Until know, in the preference we defined list of uri for conversion server, and then we were trying always in the order defined in the preference. But this is not optimal, when a server start to fail, it's better to try using another one. So sort list of uri in such a way to use first server having the most chance to work.
-
Arnaud Fontaine authored
Useful for SolverType._configuration_property_dict but more generally the whole history should be displayed as this view is used by developers.
-