From Lukasz Nowak:

1- Compensation is undesired. (51c8a250)

  Raise loudly with message.

2- Disallow any compensation. (3c74ed07)

3- Emit more informative log. (534b2e77)

Also minimise activity hurricane by calling expand directly.

Open Orders are searched using indexation timestamp, which allows to see them
in "windows", and does not repeat expand if not needed.

Generate activities and allow to pass the tag. Use search and activate
everywhere which will allow to walk through objects without killing the cluster
even in case of really big documents.

Avoid calling isDivergent which can take few minutes to finish.

causality_state comes from well designed causality workflow, which informs
enough about delivery state. Fetching causality_state property is extremely
fast.

Notes:

Do nothing on 'calculate' instead of disabling *_causality_interaction_workflow as
these interaction workflows do not generate activities directly, and do work
that can't be postponed.

By contrast, 'calculate' transition of delivery_causality_workflow is modified
so that no 'updateCausalityState' activity is created by default.

This commit also update list of method_id which should not call calculate_causality

Conflicts:
	bt5/erp5_crm/bt/revision

Next step is to activate more contextual listbox actions.

Move listbox select button to the right, to simplify cancellation.

WebSite redirection must be tested against different virtual host monster configuration
TODO: No idea how to fetch the ipv6 in live test

https://lab.nexedi.com/nexedi/slapos/tree/master/software/proftpd/test
was just named "test", we want the test result to be named "proftpd"
instead.

/reviewed-on nexedi/erp5!815

See 04939506

Since recent rework of isSubtreeIndexable, direct indexation of a trash bin
is fixed, but recursive indexation recursion condition broke: it stop just
above the trash bin instead of stopping just below it.

Revert "mark file uploading tests as expected failure." as these Functional Tests are not supposed to fail.

This reverts commit ade16831.

enablePrivilege, and thus UniversalFileRead used to upload files, was disabled
in Firefox 17. Since SlapOS Firefox has been upgraded, "The operation is insecure"
error is raised when uploading files. However, this doesn't mean that these tests
should be expected to fail (and if they are, they should be removed instead).

This workflow involved an Assignee who can open, close, re-open and an
Assignor who can close definitively.
This is usually configured so that accountants are Assignee and CFO is
Assignor.

We realized that re-opening a Period that was previously closed is
something we don't want the accountants to do without CFO's approval.

To support this configuration, we only allow Assignor to re-open.

Now Assignee can open and close temporarily and Assignor can re-open and
close definitively.

/reviewed-on nexedi/erp5!813

This is really a hack, which may be integrated into renderJS directly

Reduce potential Zelenium test timeout by waiting for iframe to be loaded one by one

This check got lost when the first isSubtreeIndexable call was done on
parent document and not on self.

This partially reverts:

commit 76e3c115
Author: Vincent Pelletier <vincent@nexedi.com>
Date:   Mon Dec 10 16:40:48 2018 +0900

    Base: Fix isAncestryIndexable implementation.

as it accidentally carried over a totally unrelated (and unfinished)
change.

Start checking isSubtreeIndexable on parent document, not on current
document.
This bug broke Trash Bins indexation (and should not affect anything else,
as only Trash Bins prevent content indexation currently).

Extent trash tool unit test to verify actual indexation, and not just
indexability API.

Fixup nexedi/erp5@559c5e8b

See nexedi/erp5@994d8369

/reviewed-on nexedi/erp5!768

This should be tested even if it currently fails with "The operation is insecure"
when trying to upload local ODS files.

erp5_configurator_standard_ui_test: Fix testFunctionalConfigurator failures with erp5testnode (b955dbe0).

The following error occurred because setupAutomaticBusinessTemplateRepository()
was called and only added bt5/ directory but not bootstrap bt5s directory:
  BusinessTemplateMissingDependency: While analysing erp5_dhtml_style the following dependency could not be satisfied: erp5_xhtml_style ()
  Reason: Business Template could not be found in the repositories

Instead assume that bt5 repositories are set up properly.

Also, running through erp5testnode requires apache-backend Timeout to be
increased as waiting for upgrader activities to be processed can take
~15 minutes (!377).

[erp5_core] Follow guidelines for Actions on portal types Catalog and Catalog Tool by adding dialog before executing

Also, Cleanup useless actions and functions

/reviewed-on !811

* Assorted small fixes so that form comply to conventions
* Minimal fixes of invalid html
* make `mixin` usable in type definition 

The context is I was working on a custom configurator involving some matrixboxs, so I needed a simple business configuration item just to store the matrix result. This was possible with mixin, I just made a portal type based on Item class, enabling mxins for `Matrix` and `BusinessConfiguratorItem` and I did not have to define a class ( not sure this is really better ).

Then the matrixbox was not rendering properly, because browser was confused by the broken html and build a "different DOM" and selectors did not apply. This is what `configurator: fix (a bit) invalid HTML` addresses.

While doing this, fix some minor problems found with forms.

/reviewed-on nexedi/erp5!814

Insert fields in a <div>, not in a <table>, fields are not valid table
elements (they are not <tr>).

Configurator still produce invalid HTML, this seem to be the minimal fix
to have matrixboxs rendered properly without having to rewriting all
configurator page templates.

So that all string fields have same width

If user still has a cookie from a previous run this this will cause
problems.

This is a dirty workaround. Why configurator has to use cookies ?

https://www.erp5.com/erp5-HowTo.Create.Action.Dialogs
> The action must use an intermediate dialog, where the user can enter parameters.

Also allow to set a name for the business configuration that will be
created.

 * fix typo in column name
 * add editable field for correct display

I'm not sure this workflow is used, just fix the transition which were
using non existant dialog or wrong transitions names.

... otherwise when nothing is selected it looks like something is set.

Also translate and sort output.

Slapos build does not seem to support gif.

* it should be a *list* mode listbox (it was a view mode)
* listbox column title should be the portal type name ( no written rule for this apparently )
* listbox title should be plural of portal type https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#set-listbox-title-to-plural-of-portal-type-title-if-applicable

my_view_mode_listbox_configuration_save should use my_view_mode_listbox as target, not my_list_mode_listbox

https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#place-simulation-and-validation-fields-at-bottom-of-right-group