Commits · 958b993c02db6200ebaa2f8e79c2675574f0239a · alecs_myu / erp5

14 Feb, 2008 6 commits

Vincent Pelletier authored Feb 14, 2008

Rename some variables which had too-generic names.
Use a set instead of a list when used with "in".
Use a set instead of a value-less dict.
Use string slice instead of "tsartswith" method.
Use 'iter...' variations of dictiteration methods.
Use 'itervalues' instead of 'iteritems' + item lookup by key.
Do not check if a role to skip is already present in new role list.
Fetch instance methods just once when called in a loop.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19312 20353a03-c40f-0410-a6d1-a30d3c3de9de

958b993c

tests/testERP5Catalog.py: · 48b0cdcd

Vincent Pelletier authored Feb 14, 2008

  Revert 19128, 19173.
  Update test_check_security_table_content to new security table design decisions.
CatalogTool.py:
  Only index a local role if this precise local role grants View permission.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19311 20353a03-c40f-0410-a6d1-a30d3c3de9de

48b0cdcd

Encode local_roles to UTF-8 · 9cd0cdf4

Romain Courteaud authored Feb 14, 2008


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19310 20353a03-c40f-0410-a6d1-a30d3c3de9de

9cd0cdf4

put Zuite_waitForActivities before and after to add/delete. · a6f9ca64
Yusei Tahara authored Feb 14, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19309 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
a6f9ca64

Fix form title on Drawing_viewAsWeb · a580835a

Jérome Perrin authored Feb 14, 2008

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19308 20353a03-c40f-0410-a6d1-a30d3c3de9de

a580835a

Respect field naming conventions http://www.erp5.org/HowToCreateNewForms · 03aaca22
Jérome Perrin authored Feb 14, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19307 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
03aaca22

13 Feb, 2008 15 commits

Call the generic script Base_checkConsistency, which deals properly with... · 99322353

Jérome Perrin authored Feb 13, 2008

Call the generic script Base_checkConsistency, which deals properly with translation of ValidationFailed

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19305 20353a03-c40f-0410-a6d1-a30d3c3de9de

99322353

use the last part from the path as business template ID, this makes it possible · c50baab4

Jérome Perrin authored Feb 13, 2008

to use the URI of a business template in getBusinessTemplateList and make it
installed from there.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19303 20353a03-c40f-0410-a6d1-a30d3c3de9de

c50baab4

Do not display embedded document. · 4592c8f4

Romain Courteaud authored Feb 13, 2008

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19302 20353a03-c40f-0410-a6d1-a30d3c3de9de

4592c8f4

Do not display embedded document in MyContent · eed64005

Romain Courteaud authored Feb 13, 2008

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19301 20353a03-c40f-0410-a6d1-a30d3c3de9de

eed64005

Implementent test by following the description. And it is failing currently. · 0657413f
Romain Courteaud authored Feb 13, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19300 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
0657413f

* PackingList_copyOrderProperties: remove " 1 or " at the beginning of if statement · b7288a06

Alexandre Boeglin authored Feb 13, 2008

* packing_list_workflow/transitions/stop_action: disable stop_action from confirmed state on a Sale Packing List, as start transition after script calls the builder, and the default config shouldn't allow bypassing it.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19299 20353a03-c40f-0410-a6d1-a30d3c3de9de

b7288a06

Add a separate test for roles_and_user checks. · ffaf0bda

Vincent Pelletier authored Feb 13, 2008

Also, revert commit 19284 since this check if done in new test.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19298 20353a03-c40f-0410-a6d1-a30d3c3de9de

ffaf0bda

Fix typo in comment. · 8f6a98e3

Vincent Pelletier authored Feb 13, 2008


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19297 20353a03-c40f-0410-a6d1-a30d3c3de9de

8f6a98e3

Rewrite comment about local roles to explain desired code behaviour. · f3a737d1

Vincent Pelletier authored Feb 13, 2008

Rewrite local roles handling code to fix a bug introduced in commit 19184: if one local roles for one user granted view permission, all local roles (except Owner) of all users were inserted in the security table. Unit test will be added soon.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19296 20353a03-c40f-0410-a6d1-a30d3c3de9de

f3a737d1

Wrong message for 'message_incorrect_type' constraint error message. · 7eae200e
Jérome Perrin authored Feb 13, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19295 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
7eae200e

- money deposit should block the action of closing the couter date only in the · 2d7a3823

Sebastien Robin authored Feb 13, 2008

confirmed state
- allow to disable the check of the current date when closing the counter date,
this is enabled by default, but usefull to disable it in unit test

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19294 20353a03-c40f-0410-a6d1-a30d3c3de9de

2d7a3823

use INFO instead of DEBUG for activity tracking. · 51193bc3
Kazuhiko Shiozaki authored Feb 13, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19292 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
51193bc3

Add test for Quoted String · c9701702

Nicolas Delaby authored Feb 13, 2008

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19291 20353a03-c40f-0410-a6d1-a30d3c3de9de

c9701702

Do not use "dict" as a variable name, since it's also a type. · 344e7842
Vincent Pelletier authored Feb 13, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19290 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
344e7842
Comment in details. Do not repeat the same code. Fix a variable name. · d0524a36
Yoshinori Okuji authored Feb 13, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19289 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
d0524a36

12 Feb, 2008 19 commits

* Add Discount and Payment Condition in allowed portal types of Sale Packing List · b0d033de
Alexandre Boeglin authored Feb 12, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19288 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
b0d033de

Revert 19286. · bf32263d

Vincent Pelletier authored Feb 12, 2008


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19287 20353a03-c40f-0410-a6d1-a30d3c3de9de

bf32263d

Remove Owner key before iterating on the dictionary to avoid testing at each iterration. · da1a0590
Vincent Pelletier authored Feb 12, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19286 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
da1a0590
Do not create any security table entry when role is "Owner". · 5fbdcc5f
Vincent Pelletier authored Feb 12, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19285 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
5fbdcc5f

Improve test_60_OwnerIndexing to also check that Owner role does not cause... · 59c51ebf

Vincent Pelletier authored Feb 12, 2008

Improve test_60_OwnerIndexing to also check that Owner role does not cause insertions to roles_and_users table.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19284 20353a03-c40f-0410-a6d1-a30d3c3de9de

59c51ebf

2007-02-12 kazuhiko · e5d4da15

Kazuhiko Shiozaki authored Feb 12, 2008

* use related_simulation_movement_path_list to reduce activity dependencies.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19283 20353a03-c40f-0410-a6d1-a30d3c3de9de

e5d4da15

* using a "hard" filter on portal_type was not a good solution, use a better sort method instead. · 7fdf58d3
Alexandre Boeglin authored Feb 12, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19280 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
7fdf58d3
in SupplyLine_asPredicate and SupplyLine_asPredicate, deal with both source and destination. · 92275f51
Alexandre Boeglin authored Feb 12, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19279 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
92275f51

Kazuhiko Shiozaki authored Feb 12, 2008

pass related_simulation_movement_path_list to after building script (if it accepts). this can be useful to reduce activity dependencies.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19278 20353a03-c40f-0410-a6d1-a30d3c3de9de

59869e6e

* _pricingSortMethod: Destination is acquired from parent on supplies, no need · a6abeda7

Alexandre Boeglin authored Feb 12, 2008

  to do it manually.
* getPriceParameterDict: filtering on portal type is not the correct way,
  revert previous change.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19277 20353a03-c40f-0410-a6d1-a30d3c3de9de

a6abeda7

Test that the default pricing model can deal with purchase and sale supplies, · f96e9016

Alexandre Boeglin authored Feb 12, 2008

with and without source or destination set.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19276 20353a03-c40f-0410-a6d1-a30d3c3de9de

f96e9016

Clean up the regular expressions. · 69104370

Yoshinori Okuji authored Feb 12, 2008

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19275 20353a03-c40f-0410-a6d1-a30d3c3de9de

69104370

Fix the test. · d0c7599a

Yoshinori Okuji authored Feb 12, 2008

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19274 20353a03-c40f-0410-a6d1-a30d3c3de9de

d0c7599a

2008-2-12 yusei · 8efa8f52

Yusei Tahara authored Feb 12, 2008

* Fixed amount search bug.
(I did not remove movement table for the present.)

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19273 20353a03-c40f-0410-a6d1-a30d3c3de9de

8efa8f52

Fix docstring & typo in docstring. · 283e659a

Vincent Pelletier authored Feb 12, 2008


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19272 20353a03-c40f-0410-a6d1-a30d3c3de9de

283e659a

User can edit stop date on document: update unit test to do so. · 6f9db67c
Vincent Pelletier authored Feb 12, 2008
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19271 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
6f9db67c

Allow user to input stop_date on mutilated banknotes. · 11c4eb13

Vincent Pelletier authored Feb 12, 2008

Do not use current "finish" transition date as stop date.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19270 20353a03-c40f-0410-a6d1-a30d3c3de9de

11c4eb13

Set default security on erp5_calendar module. · dff55e48

Jérome Perrin authored Feb 12, 2008

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19269 20353a03-c40f-0410-a6d1-a30d3c3de9de

dff55e48

Fix module title capitalisation · d08c1710

Jérome Perrin authored Feb 12, 2008


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@19268 20353a03-c40f-0410-a6d1-a30d3c3de9de

d08c1710