1. 16 Oct, 2018 2 commits
    • Jérome Perrin's avatar
      Do not set any TMP environment variables · 9ca803bb
      Jérome Perrin authored
      This reverts daa833ea ( !3 ) and extend it to not set `$TMP` either.
      
      De facto, setting only `$TMP` was never effective ( see also [#20120530-132221B](https://nexedi.erp5.net/bug_module/20120530-132221B) ) and as we saw in !3 (comment 67059) it causes more harm than good.
      
      The conclusion so far is that environment variables related to temporary files should be handled by the parent process. The parent process is responsible for providing a directory short enough so that we can create unix sockets in `$TMPDIR`  and to clean up this directory afterwards.
      
      
      In a pure buildout it could be:
      
      ```bash
      tmpdir=$(mktemp -d)
      trap 'rm -rf $tmpdir' SIGINT SIGTERM
      TEMP=$tmpdir TMPDIR=$tmpdir TMP=$tmpdir buildout
      rm -rf $tmpdir
      ```
      
      /reviewed-on !8
      9ca803bb
    • Jérome Perrin's avatar
      Don't set TMP environment variable · f101b03b
      Jérome Perrin authored
      It was inconsistent to only set TMP and not TEMP / TEMPDIR. In the case
      of slapos, it should be set by slapos node software
      
      Most installation seem to cleanup tmp properly, so the use case cleaning
      up seem not critical.
      
      This TMP was also used to know what new files have been created, by
      considering files newer that the creation date of this directory.
      Compare the file dates with the creation of the source directory instead
      ( xxx__compile__ )
      f101b03b
  2. 04 Oct, 2018 1 commit
  3. 02 Oct, 2018 2 commits
  4. 19 Sep, 2018 1 commit
  5. 18 Sep, 2018 1 commit
  6. 27 Aug, 2018 2 commits
  7. 22 Aug, 2018 3 commits
  8. 21 Aug, 2018 2 commits
  9. 20 Aug, 2018 1 commit
  10. 01 Aug, 2018 1 commit
  11. 31 Jul, 2018 1 commit
  12. 22 Jun, 2018 1 commit
  13. 31 May, 2018 1 commit
    • Xiaowu Zhang's avatar
      Reimplement shared features · 5239a27d
      Xiaowu Zhang authored
      1.use shared-part in [buildout] section to define shared path
      2.shared option is True or Flase
      3.a magic substitution @@LOCATION@@ is used to for dynamic path
      5239a27d
  14. 28 Mar, 2018 1 commit
    • Jérome Perrin's avatar
      fixup! Fix random test failure with make flags on test node · aa5a651b
      Jérome Perrin authored
      ```
      ======================================================================
      ERROR: /srv/slapgrid/slappart0/parts/slapos.recipe.cmmi/slapos/recipe/cmmi/README.txt
      Doctest: README.txt
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/opt/slapgrid/298b8e2a56fa3803aa68aa4cfe6a3b96/parts/python2.7/lib/python2.7/doctest.py", line 2194, in setUp
          self._dt_setUp(test)
        File "/srv/slapgrid/slappart0/parts/slapos.recipe.cmmi/slapos/recipe/cmmi/tests.py", line 26, in setUp
          os.environ.pop('MAKEFLAGS')
        File "/opt/slapgrid/298b8e2a56fa3803aa68aa4cfe6a3b96/parts/python2.7/lib/python2.7/os.py", line 505, in pop
          return self.data.pop(key, *args)
      KeyError: 'MAKEFLAGS'
      ```
      aa5a651b
  15. 09 Mar, 2018 1 commit
    • Jérome Perrin's avatar
      Fix random test failure with make flags on test node · 36b9d633
      Jérome Perrin authored
      When running under testnode, there was sometimes this failure:
      
      ```
      File "/srv/slapgrid/slappart8/srv/testnode/bee/inst/test0-0/parts/slapos.recipe.cmmi/slapos/recipe/cmmi/README.txt", line 521, in README.txt
      Failed example:
          print(system(buildout))
      Expected:
          Uninstalling package.
          Installing package.
          package: [ENV] CFLAGS = -I/sw/include
          package: [ENV] LDFLAGS = -L/sw/lib -L/some/extra/lib
          package: [ENV] TMP = /sample_buildout/parts/package/tmp
          package: Applying patches
          patching file configure
          patching file Makefile.dist
          patched-configure --prefix=/somewhere/else --with-threads --without-foobar
          building patched package
          installing patched package
          installing patched package-lib
          <BLANKLINE>
      Got:
          Uninstalling package.
          Installing package.
          package: [ENV] CFLAGS = -I/sw/include
          package: [ENV] LDFLAGS = -L/sw/lib -L/some/extra/lib
          package: [ENV] TMP = /sample_buildout/parts/package/tmp
          package: Applying patches
          patching file configure
          patching file Makefile.dist
          patched-configure --prefix=/somewhere/else --with-threads --without-foobar
          building patched package
          installing patched package-lib
          installing patched package
          <BLANKLINE>
      ```
      
      The order of in which `installing patched package-lib` and ` installing patched package` are printed is not always same.
      
      This test does `make install install-lib` with a Makefile containing:
      
      ```
      all:
              @echo building package
      
      install:
              @echo installing package
      
      install-lib:
              @echo installing package-lib
      ```
      
      @vpelletier  and I investigated this and he pointed out that order of parts depends is not stable when make is invoked with `-j` option.
      
      Turned out that [on test node](https://nexedi.erp5.net/test_result_module/20180308-55459479/7) `MAKEFLAGS` is  set to `-j12`.
      
      
      /reviewed-on nexedi/slapos.recipe.cmmi!5
      36b9d633
  16. 07 Mar, 2018 4 commits
  17. 06 Jun, 2017 2 commits
  18. 05 Jun, 2017 5 commits
  19. 30 May, 2017 1 commit
  20. 06 Apr, 2017 1 commit
  21. 03 Apr, 2017 2 commits
  22. 14 Mar, 2017 2 commits
  23. 09 Mar, 2017 1 commit
  24. 08 Mar, 2017 1 commit