Commit 4e2fdaea authored by Vincent Pelletier's avatar Vincent Pelletier

Improve backward compatibility by accepting extra keyword parameters.

parent 05b42add
...@@ -141,12 +141,16 @@ class TestResultLineProxy(RPCRetry): ...@@ -141,12 +141,16 @@ class TestResultLineProxy(RPCRetry):
def stop(self, test_count=None, error_count=None, failure_count=None, def stop(self, test_count=None, error_count=None, failure_count=None,
skip_count=None, duration=None, date=None, command=None, skip_count=None, duration=None, date=None, command=None,
stdout=None, stderr=None, html_test_result=None): stdout=None, stderr=None, html_test_result=None, **kw):
""" """
Notify server of test completion. Notify server of test completion.
Without any parameter, notifies of a test failure which prevents any Without any parameter, notifies of a test failure which prevents any
precise reading (step count, how many succeeded, etc). precise reading (step count, how many succeeded, etc).
BBB: extra named arguments are deprecated (if some are really needed,
they must be declared as explicit parameters, with proper default
value).
""" """
status_dict = { status_dict = {
'test_count': test_count, 'test_count': test_count,
...@@ -156,6 +160,9 @@ class TestResultLineProxy(RPCRetry): ...@@ -156,6 +160,9 @@ class TestResultLineProxy(RPCRetry):
'duration': duration, 'duration': duration,
'date': date, 'date': date,
} }
if kw:
self._logger.info('Extra parameters provided: %r', kw)
status_dict.update(kw)
if command is not None: if command is not None:
status_dict['command'] = command status_dict['command'] = command
if stdout is not None: if stdout is not None:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment