- 11 Mar, 2019 40 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
As shown in the following example, on a big catalog table, MariaDB is able to use several indices at the same time ('...' are obfuscated unique values): > analyze select SQL_NO_CACHE uid, relative_url from catalog where reference='...' OR relative_url='...'; +------+-------------+---------+-------------+------------------------+------------------------+---------+------+------+--------+----------+------------+--------------------------------------------------+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | r_rows | filtered | r_filtered | Extra | +------+-------------+---------+-------------+------------------------+------------------------+---------+------+------+--------+----------+------------+--------------------------------------------------+ | 1 | SIMPLE | catalog | index_merge | Reference,relative_url | Reference,relative_url | 768,767 | NULL | 2 | 2.00 | 100.00 | 100.00 | Using union(Reference,relative_url); Using where | +------+-------------+---------+-------------+------------------------+------------------------+---------+------+------+--------+----------+------------+--------------------------------------------------+ 1 row in set (0.00 sec) So mixing different dependency types with OR should be fine (no need to split into more subqueries and join with UNION).
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Jérome Perrin authored
-
Jérome Perrin authored
only covers interface compliance and high level parts of sending
-
Jérome Perrin authored
User triggering action to send SMS does not have view permission on Gateway
-
Jérome Perrin authored
after using Base_setDefaultSecurity to initialize security
-
Jérome Perrin authored
Implementation dependant parameters, such as message type or quality, must be defined by the gateway class, not in the common ShortMessage_send script. This should make it easier to switch implementations. Also: * send method is expected to be called once per recipient. I guess we prefer to isolate messages than to batch send messages efficiently. * send method expect relative url of sender and reciever documents, so that it can decide which properties to use. * drop `sender_title` parameter, now the gateway implementation decide what to use. * drop `test` parameter. For simulation mode, set simulation mode on the gateway instance * sms.send() no longer accept direct from_url / to_url / body message. It only supports sending what's defined on document properties. * SMSTool_afterSend will be called with message_id parameter, not message_id_list * Split interfaces in two SMS Sending / SMS Receiving.
-
Jérome Perrin authored
- fix message_type to support multitext messages - use MULTITEXT message type by default Only mobyt support this parameter, so this break the compatibility with essendex
-
Jérome Perrin authored
-
Jérome Perrin authored
The fields are displayed only if some portal types are configured as member of payment_request group. This means that currently it's not displayed by default.
-
Jérome Perrin authored
-
Ayush Tiwari authored
-
Arnaud Fontaine authored
e84d2b51 introduced template_{interface,mixin}_id BusinessTemplate properties in erp5_property_sheets without keeping backward compatibility and thus preventing update: Module Products.ERP5.Tool.TemplateTool, line 1446, in upgradeSite update_catalog=update_catalog) Module Products.ERP5.Tool.TemplateTool, line 1289, in updateBusinessTemplateFromUrl imported_bt5 = self.download(url = download_url, id = id) Module Products.ERP5.Tool.TemplateTool, line 382, in download bt = self._download_local(path, id) Module Products.ERP5.Tool.TemplateTool, line 328, in _download_local bt.importFile(path) Module Products.ERP5.Document.BusinessTemplate, line 5887, in importFile self.storeTemplateItemData() Module Products.ERP5.Document.BusinessTemplate, line 5165, in storeTemplateItemData InterfaceTemplateItem(self.getTemplateInterfaceIdList()) AttributeError: getTemplateInterfaceIdList
-
Arnaud Fontaine authored
ZODB Components: Likewise Document, add Mixin (erp5.component.mixin) and Interface (erp5.component.interface). * One Mixin/Interface class per ZODB Component. => Already the case for FS Mixin, not for Interfaces. * ZODB Components module name ('reference' property) and class name: + Mixin: FooMixin. + Interface: IFoo. Rationale: + Avoid current FS hacks: registry (Mixins, mixin_class_registry) or import all classes explicitly in __init__.py (Products.ERP5Type.interfaces). + Consistent naming. + Consistent with ZODB Documents Components. Also, modify pylint checker to handle Zope Interfaces: + E: 4, 0: Inheriting 'Interface', which is not a class. (inherit-non-class) + E: 5, 2: Method has no argument (no-method-argument)
-
Romain Courteaud authored
Follow nexedi/erp5@1664e541 It seems developpers didn't update their instances.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Stemmermann authored
-
Stemmermann authored
-
Romain Courteaud authored
Creating a Software Publication doesn't require to change the Software Product.
-
Romain Courteaud authored
And so, simplify the code logic, as product is always created before the publication
-
Romain Courteaud authored
-
Romain Courteaud authored
Do not wait too long when pushing a new application.
-
Romain Courteaud authored
Do not modify document history if nothing changed
-
Romain Courteaud authored
Set the wildcard URL on a system preference.
-
Romain Courteaud authored
Those web site do not work in offline mode, so client must revalidate the components.
-
Romain Courteaud authored
Update appcache Drop unused scripts Thanks to Vincent Bechu for his work on this commit.
-
Romain Courteaud authored
-
Vincent Pelletier authored
As noted in a comment in this BT's Base_redirect implementation, original code does raise when abort_transaction is true. Not raising in this implementation means that this script will return to caller, while it never does on original code. Also, to add insult to injury, this utterly bogus implementation interferes with transaction boundaries. So suddenly, a single publication spans over 2 transactions, which can lead to: - ZODB Connection sharing, breaking transaction isolation - the second transaction implicitly created by this abort (actually, by the next transactional connector registration to transaction) may be committed, in which case anything done after Base_redirect returns will be persistently committed, against caller's explicitly specified intent, and against all developer expectations. NEVER TOUCH TRANSACTION ! Only CMFActivity and unittests are allowed this level of access (and CMFActivity should be modified out of this exceptional state).
-
Romain Courteaud authored
Linshare Use the same configuration than ERP5 Thanks to Vincent Bechu for his work on this topic.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Sebastien Robin authored
This reverts commit fba5767e. Sorry, I went too quickly, there was difference between self and context
-
Sebastien Robin authored
-
Jérome Perrin authored
This reverts commit 7aa5fb76 > this change makes title empty when reply nexedi/erp5!823 (comment 73439) /reviewed-on nexedi/erp5!826
-
Romain Courteaud authored
-