slapos_subscription_request: The link on the sent email is from the invoice

... not from the Payment Transaction

slapos_subscription_request: (test) Link on the email comes from the invoice

master/bt5/slapos_subscription_request/SkinTemplateItem/portal_skins/slapos_subscription_request/SubscriptionRequest_processOrdered.py

@@ -30,5 +30,8 @@ if not context.SubscriptionRequest_verifyInstanceIsAllocated():
   # Only continue if instance is ready
   return
 
-if context.SubscriptionRequest_notifyPaymentIsReady(payment=first_period_payment):
+invoice = first_period_payment.getCausalityValue()
+
+# Link to be sent is the invoice one
+if context.SubscriptionRequest_notifyPaymentIsReady(payment=invoice):
   context.confirm()

master/bt5/slapos_subscription_request/TestTemplateItem/portal_components/test.erp5.testSlapOSSubscriptionScenario.py

@@ -351,7 +351,8 @@ class TestSlapOSSubscriptionScenarioMixin(DefaultScenarioMixin):
       mail_message.getTitle())
     payment = subscription_request.SubscriptionRequest_verifyPaymentBalanceIsReady()
     self.assertEqual(payment.getSimulationState(), 'started')
-    self.assertTrue(payment.getRelativeUrl() in \
+    invoice = payment.getCausalityValue()
+    self.assertTrue(invoice.getRelativeUrl() in \
                  mail_message.getTextContent())
     self.assertTrue(subscription_request.getDestinationSectionTitle() in \
       mail_message.getTextContent())