Commit f5daca6b authored by iv's avatar iv

ERP5Workflow: fix testWorklist + add XXX comment

parent 2049c8a5
...@@ -507,9 +507,9 @@ class TestWorklist(testWorkflowMixin): ...@@ -507,9 +507,9 @@ class TestWorklist(testWorkflowMixin):
self.assertEqual(['Group1', 'Group2'], worklist_value.guard.groups) self.assertEqual(['Group1', 'Group2'], worklist_value.guard.groups)
# expression # expression
worklist_value.setGuardExpression('') worklist_value.setGuardExpression('')
self.assertEqual('', worklist_value.guard.expr) self.assertEqual(None, worklist_value.guard.expr)
worklist_value.setGuardExpression('python: "Hello, world"') worklist_value.setGuardExpression('python: "Hello, world"')
self.assertEqual(worklist_value.guard.expr, 'python: "Hello, world"') self.assertEqual(worklist_value.guard.expr.text, 'python: "Hello, world"')
def test_suite(): def test_suite():
suite = unittest.TestSuite() suite = unittest.TestSuite()
......
from Products.DCWorkflow.Guard import Guard from Products.DCWorkflow.Guard import Guard
# XXX(WORKFLOW) ^ should not use DCWorkflow Guard class
from Products.CMFCore.Expression import Expression from Products.CMFCore.Expression import Expression
class GuardableMixin(object): class GuardableMixin(object):
...@@ -50,4 +51,4 @@ class GuardableMixin(object): ...@@ -50,4 +51,4 @@ class GuardableMixin(object):
# # Make sure we do not give rights to anonymous users when no guard is defined # # Make sure we do not give rights to anonymous users when no guard is defined
# #reasonable_roles.remove('Anonymous') # #reasonable_roles.remove('Anonymous')
# self.guard.roles = reasonable_roles # self.guard.roles = reasonable_roles
# return self.guard # return self.guard
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment