Better control flow.

61fc9aa8 · Patricio Cano · 31bcd9f8 · 61fc9aa8
Commit 61fc9aa8 authored Apr 11, 2016 by Patricio Cano
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 6 deletions

lib/gitlab/o_auth/user.rb lib/gitlab/o_auth/user.rb +4 -6

No files found.
--- a/lib/gitlab/o_auth/user.rb
+++ b/lib/gitlab/o_auth/user.rb
@@ -54,12 +54,10 @@ module Gitlab
          @user ||= build_new_user
        end

-        unless @user.nil?
-          if external_provider?
-            @user.external = true
-          else
-            @user.external = false
-          end
+        if external_provider? && @user
+          @user.external = true
+        elsif @user
+          @user.external = false
        end

        @user