• Jérome Perrin's avatar
    CodingStyleTest: review business template installation · 1c57528b
    Jérome Perrin authored
    We were installing erp5_upgrader with its test dependencies, so it was
    installing erp5_full_text_mroonga_catalog. We were also installing
    erp5_full_text_myisam_catalog, so we ended up with two full text
    business template installed (and the order of this installation was not
    deterministic).
    This was problematic, because we were installing all the test dependencies
    of erp5_upgrader, but we don't really need them here and one goal of
    CodingStyleTest is to install only the dependencies of tested business
    templates, as a way to verify that dependencies are correctly specified.
    
    This new approach hooks at another level, to install a full text business
    template only if the tested business template has a dependency to the
    virutal "erp5_full_text_catalog" bt, but no dependency to a concrete bt
    (which happens for example in erp5_base) and to install erp5_upgrader
    without its test dependencies.
    
    As a result, we also run without erp5_base unless it's an explicit
    dependency.
    
    This also reverts commit ab44309f (
    full_text_myisam_catalog: skip coding style test) that is no longer
    needed with this new approach.
    1c57528b
CodingStyleTest.py 6.06 KB