/reviewed-on nexedi/erp5!1757

In 79fa584e we moved
some security definition from wendelin to erp5, but we didn't add any
tests anywhere. Recent project based tests revealed that this
migration actually failed [1]. We should therefore add a test for
this.

[1] wendelin@f8678468 (comment 181134)

/reviewed-on !1757

This reduces dependency on DCWorkflow and cleanup StateChangeInfo monkey patch.

See merge request nexedi/erp5!1537

And the Product was removed in recent ERP5 SR.

This patch seems not needed

This is in SyncMLUtils

Now this is defined from new workflows, we no longer need the
DCWorkflow version

This was only useful during the transition to ERP5 Workflow, now
that workflows are migrated, Category API (setDestination) is more
natural, so there's no reason to keep this patch

Test setup monkey-patched some function which we removed when merging
Zope4 support. This function was used in translationContext, it was
working fine in the tests, because the function was here thanks to the
monkey-patch, but it failed with ImportError when used for real.

This fixes the import to use the real getRequest and drop the patch to
prevent similar problems.

According to https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000027804775/
ValidDate is the date when the transaction was validated ( "16. La date
de validation de l'écriture comptable"), this implementation was simply
returning the modification date, which was not always correct, for
example after causality state was recaculated.

This keeps the `getModificationDate` fallback for cases where FEC is
used with some non validated transactions, in order to keep compatibility

   On the implementation 0 dont set stop date on the Assignment

  If preferences sets a negative duration, don't set stop/start dates on
assignments.

See merge request nexedi/erp5!1754

This fixes some regressions introduced by nexedi/erp5!1545 when searching the catalog for non ascii text

See merge request nexedi/erp5!1752

Using unicode with a catalog key or related key got broken in the merge
of zope4 support, but using unicode on a translated key (such as
translated_portal_type or translated_validation_state_title) was not
working before.

it supports text, but unless they have non-ASCI characters, so it's
better to always pass bytes.

In original Products.ZSQLMethods, this is text, we want to keep the
same semantics and encode only at a lower level.

MySQLdb's string_literal is a method from the C API and the name is not
natural for python programmers, because it manipulates bytes. It
supports str, unless they have non ASCII characters, so it's better to
always pass bytes.

On python2, this change repairs a regression visible when searching
catalog with translated related keys. This regression was introduced in
the merge of zope4 support, more specifically with 610972af (py3:
Update Shared.DC.ZRDB.{sqltest,sqlvar} monkey patches., 2022-04-16),
because with the new version of the patches this method gets passed
unicode strings, which is fine, unless they contain non ASCII characters.

This reverts commit 149fdd1d.

This did not support the case of updating old emails for which
url_string was set, it was setting coordinate_text and causing
emails to have two properties ( url_string to the old value
and coordinate_text to the new value ).

See discussion on nexedi/erp5@149fdd1d (comment 180744)

- make the editor bigger
- use monospace font for params

This can happen with cross origin document, when using open on another
domain. In that case selenium crashes and the test never finishes, this
allows selenium to finish and report the error.

With 12f110d4 (testTableStructureMigration: update test after
mariadb 10.3.38, 2023-02-22) we changed the test to support mariadb >=
10.3.38 but it broke the test under 10.3.35.

This makes the test support both 10.3.35 and 10.3.38.

We now must use Zope4 to export business templates to commit on ERP5
master branch

Duplicating the id is bad. Checking the meta_type is not perfect, but it
is one step better.

Updating pandas to 0.24.2 revealed as :

      File "develop-eggs/astroid-1.3.8+slapospatched001-py2.7.egg/astroid/raw_building.py", line 360, in _set_proxied
        return _CONST_PROXY[const.value.__class__]
    KeyError: <type 'numpy.ufunc'>

when linting code referencing pandas. The problem is actually with
some numpy `ufunc`, such as numpy.sin, but we don't seem to have code
using it in the test suite.

Creating Stripe Payment Session and HTTP Exchange in the same transaction can raise conflict errors and when it happens, we already created the session on the Stripe side.

With this, when this happens, we receive one useless webhook to inform that the session has expired.

Also, batch_mode was removed because we only use it in tests. The tests were updated to use like in production.

This change will probably avoid the issue below:

```
------
2023-03-01 13:03:33,503 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/stripe_payment_session_module/20230301-1B990F0, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/stripe_payment_session_module/20230301-1B990F0', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=...
------
2023-03-01 13:03:33,516 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/system_event_module/20230301-9DDE8DD8, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/system_event_module/20230301-9DDE8DD8', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=...
------
2023-03-01 13:03:33,549 INFO ZPublisher.Conflict ReadConflictError at ......_startStripePaymentSession: database read conflict error (oid 0x06be91ef, serial this txn started with 0x03eec0ca6bdaf611 2023-03-01 10:50:25.278590, serial currently committed 0x03eec0d78f096a55 2023-03-01 11:03:33.524245) (12 conflicts (0 unresolved) since startup at Tue Jan 17 03:21:57 2023)
------
2023-03-01 13:03:35,057 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/stripe_payment_session_module/20230301-1E233DB, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/stripe_payment_session_module/20230301-1E233DB', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=...
------
2023-03-01 13:03:35,066 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/system_event_module/20230301-5C3B7E3, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/system_event_module/20230301-5C3B7E3', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=...
```

See merge request nexedi/erp5!1747

erp5_core: remove Guard Role field in Worklist_view, as it should be defined in predicate listbox at the bottom.

Creating Stripe Payment Session and HTTP Exchange in the same transaction can raise conflict errors and when it happens, we already created the session on the Stripe side.

With this, when this happens, we receive one useless webhook to inform that the session has expired.

Also, batch_mode was removed because we only use it in tests. The tests were updated to use like in production.