There have been a regression recently

SKINDATA is an implementation detail that should not be accessed from
this level.

Done through various 2to3 fixers (zope.fixers, modernize, future) and manual
changes. This is a single commit so that we have a clearer picture of how code
converted with my2to3 should look like.

Except straightforward @implementer decorator 2to3 fixer, only product/ folder
was considered as the goal was to be able to create an ERP5Site.

* Use @implementer decorator introduced in zope.interface 3.6.0 (2010):

  The implements syntax used under Python 2.X does not work under 3.X, since it
  depends on how metaclasses are implemented and this has changed. Instead it
  now supports a decorator syntax (also under Python 2.X).

  Applied thanks to 2to3 `zope.fixers` package.

* Use `six.moves` rather than `future` install_aliases() feature because the
  latter use unicode_literals and "wraps" module aliases so that unicode() are
  returned for text rather than str() (Python2 standard library). This notably
  breaks BusinessTemplate code which uses urllib quote() for filesystem paths...

* No more unbound methods in python3 so use six.get_unbound_function().

* dict.(iteritems,iterkeys,itervalues)() => six.\1(dict) thanks to `dict_six`
  2to3 fixer from `modernize`:
  $ python-modernize -w -f dict_six product/

* Manually make sure that dict.{items,values,keys}() returns a real list when it
  is latter modified rather than a dict_{items,values,keys} (ensure_list()). By
  default, 2to3 blindly does list(dict.{items,values,keys}()) which is not
  acceptable from performances point of view. With my2to3, this will be possible
  to handle such case automatically.

* Replace cStringIO.StringIO() by six.moves.cStringIO() (a module alias for
  cStringIO.StringIO() on py2 and io.StringIO() on py3).

* Use six.text_type which maps to unicode() on py2 and str() on py3. This also
  makes a clearer difference between text and binary strings.

* Replace map()/filter() with lambda function by list comprehension (this has
  the benefit to avoid casting to list for py3 as it returns iterators).

When rendering a proxy field, 3 different fields can come in play:
1. the field to be rendered
3. the template field (i.e. not a proxy field) that knows how to render
2. possibly an intermediate proxy field that contains the value to render

What's difficult when rendering a proxy field is to take the above 3 fields
into account and this commit does it by creating a temporary field:
1. 'field' variable in TALES
2. the value
3. the code

Before this commit, 1 could be wrong.

Also, `__code__` has been introduced in Python 2.6 (for forwards compatibility
with Python 3) as an alias to func_code which has been completely removed in
Python 3.

This fixes testFunctionalCore failures:
  [...]
    Module ZPublisher.mapply, line 53, in mapply
      code = f.__code__
  AttributeError: 'DefaultGetter' object has no attribute '__code__'

For now this only checks that every entries in .tales are also in .values
so that .has_value works as expected. This also supports repairing the
structures with fixit argument.

We could check more, because there are other problems with proxy fields
internal structures:
 - sometimes some keys are in .values / .tales but not in .delegated_list
   this seem to happen after changing the target to a field of a different
   type, with different keys.
 - .delegated_list are not always sorted

otherwise TALES in input_style does not work and changes in the original proxy field will not be reflected.

Patched class' getCurrentSkinName expects a 4-tuple, although it ignores
the first value, so provide a placeholder.

So, Relation Fields in ListBox were ignored during validation as the input
value is compared with the current (default), thus the field could not be
cleared as the value from the actual object was not retrieved at all.

Before, the field value cache was only invalidated on the node where a field
has been modified, so similarly to reset of ZODB Components, implement
synchronization on all nodes through ZODB Cache Cookie.

This is a quick workaround, the main problem is that get_request is monkey
patched to use a completly different implementation in tests, and in some cases
this monkey patch is not properly applied.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@41473 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@39966 20353a03-c40f-0410-a6d1-a30d3c3de9de

Add a hack to work around a bug that CheckBoxField may not even try to get a property value, because it has a default value 0 in the field definition itself. The same hack was performed against Form.py but this has been disabled mistakenly for a while, because monkey-patched methods were overridden in ProxyField.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@38432 20353a03-c40f-0410-a6d1-a30d3c3de9de

getTransactionalVariable has always been implemented to return a global
cache object (1 per thread): old implementation used the given context only to
have access to the portal.

So we enforce this with a warning to make sure people don't expect retrieving
1 cache object per given context.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@38366 20353a03-c40f-0410-a6d1-a30d3c3de9de

Conflicts:
	bt5/erp5_base/bt/revision
	bt5/erp5_simulation/DocumentTemplateItem/InvoiceSimulationRule.py
	bt5/erp5_simulation/bt/revision
	bt5/erp5_trade/SkinTemplateItem/portal_skins/erp5_trade/Base_viewTradeFieldLibrary.xml
	bt5/erp5_trade/bt/change_log
	bt5/erp5_trade/bt/revision
	products/ERP5/Document/BusinessPath.py
	products/ERP5/Document/SimulationMovement.py
	products/ERP5/Document/TradeCondition.py
	products/ERP5/Document/TradeModelLine.py
	products/ERP5/bootstrap/erp5_mysql_innodb_catalog/bt/revision
	products/ERP5Type/ERP5Type.py

git-svn-id: https://svn.erp5.org/repos/public/erp5/sandbox/amount_generator@37129 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@35769 20353a03-c40f-0410-a6d1-a30d3c3de9de

implementation, then stop caching and call registered special function
which should behave as the special get_value method. This change fixes
a bug tested on TestProxyField.test_proxifyParallelListField.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@35458 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@33752 20353a03-c40f-0410-a6d1-a30d3c3de9de

Use _getOb instead of getattr twice.
Thanks Julien for the tips


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@33643 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@33641 20353a03-c40f-0410-a6d1-a30d3c3de9de

XXX this should be done automatically


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32849 20353a03-c40f-0410-a6d1-a30d3c3de9de

 - explicitely define the skin folder in the proxy field's form ID field.
 - surcharge a field library for a custom project by only putting inside
   the modified fields. Untouched field can be left inside standard
   field library.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@30848 20353a03-c40f-0410-a6d1-a30d3c3de9de

On the way to Zope 2.12, Reform imports, specially from Globals (replacing it with Products.ERP5Type.Globals on the products that depend on ERP5Type), convert Interface uses to zope.interfaces, and remove CMFMailIn references with blessings from Jerome.

git-svn-id: https://svn.erp5.org/repos/public/erp5/sandbox/portal_types@29459 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@28671 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@27022 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@25621 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@23810 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@23806 20353a03-c40f-0410-a6d1-a30d3c3de9de

  stored in zodb, or if target field is defined by a TALES.
* cache an error if template field cache is None.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@23796 20353a03-c40f-0410-a6d1-a30d3c3de9de

* a small optimisation.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@23756 20353a03-c40f-0410-a6d1-a30d3c3de9de

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@22703 20353a03-c40f-0410-a6d1-a30d3c3de9de

Added TypeError in exceptions. This prevent make the Proxy field uneditable when you define wrong tales by mistake for proxy form id or proxy field id.



git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@22687 20353a03-c40f-0410-a6d1-a30d3c3de9de

Make proxyfield's WidgetDelegatedMethod lazily retrieve proxyfied method's func_code, so that it's easier to pinpoint underlying method.
Use case: when a widget rendering method raises and the rendered field is a proxyfield, func_code cans be read *after* call raised.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@21956 20353a03-c40f-0410-a6d1-a30d3c3de9de