- 07 Sep, 2018 20 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
This reapplies parts of 9a84ef83 , but a different server side approach: * use portal_workflow API to count worklists * introspect workflow to build queries * use translated state in the query, trying to be a bit more user friendly. We could do for portal_type as well. This workarounds #20180907-24A654C a problem with queries generated by gadget worklist does not seem to support complex queries with multiple values ( local_roles: ['Assignor', 'Assignee'] ). This code generates queries: ``` ( ( local_roles: "Assignee" OR local_roles: "Assignor" ) AND portal_type: "Support Request" AND translated_simulation_state_title: "Opened" ) ``` where the previous version generated queries like: ``` ( portal_type: "Support Request" AND simulation_state: "validated" AND local_roles: ( "Assignee" OR "Assignor" ) ) ``` which did not match anything. Maybe because local_roles is handled differently in catalog
-
Jérome Perrin authored
This reverts commit 9a84ef83. Eventhough there's a delay due to cache, the default worklist implementation is efficient and worklist is translated.
-
Jérome Perrin authored
-
Jérome Perrin authored
To make it easier to test worklists and dashboard. SR-15 Crashed! is Opened SR-16 Boom! is Suspended SR-17 Done is Closed
-
Jérome Perrin authored
So that ERP5TypeTestCase user is Assignee/Assignor and we can test worklists
-
Jérome Perrin authored
Because worklists tests expect to run with ERP5TypeTestCase user, and this test uses another user.
-
Jérome Perrin authored
* Preferences use same icons as other OfficeJS apps * Support Request use an "help"/"support" icon
-
Jérome Perrin authored
-
Jérome Perrin authored
This is not used in this interface
-
Jérome Perrin authored
now that we have ERP5 Login, reference is just reference.
-
Jérome Perrin authored
-
Jérome Perrin authored
Searchable and sortable
-
Jérome Perrin authored
now that we have ERP5 Login, reference is just reference.
-
Jérome Perrin authored
It was displaying "False" when no requester, display nothing instead.
-
Jérome Perrin authored
add reference which was misisng in searchable / sortable sort in same order as columns + more columns
-
Sebastien Robin authored
-
Jérome Perrin authored
I made a mistake rebasing & applying the patch to master, so the test added in nexedi/erp5!726 (comment 65067) did not reach master. This reapplies this part. Thanks Seb for noticing !
-
Jérome Perrin authored
On the traditional editor (from portal_component), selected text was not highlighted
-
Jérome Perrin authored
This is something the webmaster will define. Also, initialize available languages like this will select a random default language, which the webmaster might not understand.
-
- 05 Sep, 2018 4 commits
-
-
Nicolas Wavrant authored
-
Nicolas Wavrant authored
-
Nicolas Wavrant authored
-
Georgios Dagkakis authored
So that a declaration like: context.getUrlFor({command: 'display_action', options: {jio_key: "document", page: "action_reference"}}) can return the URL to redirect to the given action or the document
-
- 04 Sep, 2018 2 commits
-
-
Richard authored
/reviewed-on nexedi/erp5!735
-
Jérome Perrin authored
-
- 03 Sep, 2018 2 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
- 01 Sep, 2018 5 commits
-
-
Vincent Pelletier authored
Auto-generate cache_id, removing the risk of duplicating one. Inline getInstanceID as it is its only caller left. Avoid wrapping if getTransactionalVariable cannot be imported. Avoid intermediate variables, at the cost of dupicating logic but accelerating run-time. Use functools.wraps . Access _cache_sequence_number directly - these pieces of code are friends anyway, we already set a volatile property on Catalog instance. Saves one getattr and one call.
-
Vincent Pelletier authored
No backslash at EOL. Avoid splitting messages, to ease code lookup. LOG's "error" argument accepts a boolean, which removes the need to touch sys.exc_info. Use modern exception raising syntax.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
_getSelectDict was also calling itself on sub-sql_expressions, but this was useless: they would already have called it, and discarded one of its returned values. Instead, preserve both returned values in __init__ and access these attributes directly when iterating over sub-sql_expressions. Also, fold canMergeSelectDict back into its only 2 call places, saving one getattr and one call. Also, get rid of a few properties which were only used in _getSelectDict. Also, get rid of two iterable copies: sql_expression_list when it is already a list (no need to cast it again to a list, we just built one with the list comprehension), and select_dict being cast into a list when entering _getSelectDict, despite not being used (besides in extra _getSelectDict calls, which are now entirely avoided).
-
- 31 Aug, 2018 3 commits
-
-
Sebastien Robin authored
-
Jérome Perrin authored
Because some tests or softwares can chmod'ed some files to make them readonly, testnode should try to chmod the files to deletable state if deleting them fail in the first place.
-
Jérome Perrin authored
Telephone.asUrl (which is used in erp5_short_message) properly supported detailed coordinates, but had no support for coordinate text. In that case, we don't try to be to clever and just use the coordinate (almost) as is, just using the tel: prefix and removing spaces which are not legal.
-
- 29 Aug, 2018 4 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
A pprofile run shows DateTime_or_None costing 3ms per value (including all callees). While this may seem low, it is common to receive hundreds of such values in single query results (ex: web mode document & webpage lookups), so the total time spent parting dates per query can become significantly larger than the time to execute the query itself. In the case of this measure setup, 504 dates were processed for a total of 1.5 seconds. DateTime is slow to parse strings because it cannot rely on a pre-known format. With MySQL/MariaDB, the format is know for those column types, so implement specific parsing to get better performance. On the same setup, pprofile run shows a parsing time of 123µs per value in DATETIME_to_DateTime_or_None, or 65ms total. DATE_to_DateTime_or_None should not deviate significantly from this.
-
Vincent Pelletier authored
For some reason, unit tests all broke while testing this revision. The relation between both is not clear to me (this code has worked for me). In doubt, I revert it for now. This reverts commit 0057272c.
-
Vincent Pelletier authored
getRelativeUrl and restrictedTraverse are expensive operations. Do not involve them pointlessly. Also, boolean evaluation of lists is a thing.
-