- 28 Dec, 2022 1 commit
-
-
Jérome Perrin authored
-
- 27 Dec, 2022 5 commits
-
-
Jérome Perrin authored
Unlike StringIO.StringIO().tell() and open().tell(), which all return int, io.BytesIO().tell() returns long. Because io.BytesIO is used when uploading files on Zope4, this cause PropertySheetValidity errors when checking consistency, because Data.size property is expected to be int.
-
Jérome Perrin authored
Checks that created document types match constraints
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
Previously, we were using an encoded string, which in practice worked, but with python3, WSGI server will encode as latin1 (because WSGI is latin1) and already with Zope4 on python2 we have issues with testing, as functional testing fake WSGI server only accepts ascii headers [1] 1: https://github.com/zopefoundation/Zope/blob/cddecf7e/src/Testing/ZopeTestCase/functional.py#L125-L126
-
- 26 Dec, 2022 2 commits
-
-
Jérome Perrin authored
Since Zope 4, the `standard_error_message` is rendered in the context of REQUEST['PUBLISHED'], which in case of publishing a skin (page template or script) in the context of a document is is the skin itself, but for error rendering in case of erp5_web Web Site or Web Section, we expect standard_error_message_template to always be rendered in the context of the document, that's why we use REQUEST.PARENTS[0] as context. REQUEST.PUBLISHED = <PythonScript at /erp5/script used for /erp5/module/document> REQUEST.PARENTS [<Document>, <Module>, <ERP5Site>, ...]
-
Jérome Perrin authored
-
- 22 Dec, 2022 1 commit
-
-
Jérome Perrin authored
-
- 21 Dec, 2022 3 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
Ran https://github.com/python/cpython/blob/3.7/Lib/lib2to3/fixes/fix_asserts.py after adding the missing methods (assertRegex and assertRaisesRegex) on ERP5TypeTestCase. Also ran a custom fixer rewriting ```py self.assertTrue(a in b) ``` into ```py self.assertIn(a, b) ``` See merge request nexedi/erp5!1708
-
Jérome Perrin authored
Prepare for https://github.com/zopefoundation/Zope/pull/1075 ( Zope 4.8.7 ) See merge request nexedi/erp5!1707
-
- 20 Dec, 2022 2 commits
-
-
Jérome Perrin authored
-
Romain Courteaud authored
See merge request nexedi/erp5!1674
-
- 19 Dec, 2022 13 commits
-
-
Roque authored
-
Roque authored
-
Roque authored
-
Roque authored
-
Roque authored
-
Roque authored
-
Roque authored
-
Vincent Pelletier authored
Unindexation happens in a transation after the corresponding document was deleted. So there is no context available to check the type of the deleted document. So these filter expressions are meaningless.
-
Vincent Pelletier authored
Unindexation happens in a transation after the corresponding document was deleted. So there is no context available to check the type of the deleted document. So these filter expressions are meaningless.
-
Vincent Pelletier authored
Unindexation happens in a transation after the corresponding document was deleted. So there is no context available to check the type of the deleted document. So these filter expressions are meaningless.
-
Jérome Perrin authored
-
Jérome Perrin authored
The add-hoc assertin filter: -- from typing import List import lib2to3 from lib2to3.fixer_base import BaseFix from lib2to3.fixer_util import Comma, Name class FixAssertIn(BaseFix): PATTERN = """ power< any+ trailer< '.' meth=("assertTrue" | "assertFalse")> trailer< '(' comparison< (needle=any ( comp_op<'not' 'in'> | 'in' ) haystack=any) > ')' > > """ def transform(self, node: lib2to3.pytree.Node, results: List[lib2to3.pytree.Base]): needle = results['needle'] haystack = results['haystack'] meth = results["meth"][0] method_map = {True: 'assertIn', False: 'assertNotIn'} method_in = meth.value == 'assertTrue' if 'not' in str(needle.parent.children[1]): method_in = not method_in meth.replace(Name(method_map[method_in], prefix=meth.prefix)) needle.parent.children = [needle, Comma(), haystack]
-
Jérome Perrin authored
so that we can run 2to3.fix_assert
-
- 18 Dec, 2022 3 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
This updates the change to 32cead86 (xhtml_style: set a bottom margin for dialog action, 2019-05-31) that got impacted by a rule added on html and body in 5dde17a5 (xhtml_style: make editors in bottom group use full height, 2022-08-22)
-
Jérome Perrin authored
this code was latin 1, causing issues for refactoring scripts
-
- 16 Dec, 2022 10 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
Form.__call__ replaces page template call, so it is also responsible to set the content type in response. With Page Templates, ZopePageTemplate._exec (called by Shared.DC.Scripts.Bindings.__call__ and _bindAndExec) sets the response content type and calls pt_render. Form.__call__ also calls pt_render, so to behave like page template, it should also sets the response content type. In erp5_xhtml_style, we don't notice this, because global_definitions contains a setHeader call to set content type to html.
-
Jérome Perrin authored
Check that it correctly includes the web page and sets the content type header.
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
it would be good to rewrite this in a page template
-
Jérome Perrin authored
This method converts the HTML, so it should escape nasty HTML tags. Also add missing escaping when inserting the base
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
and move it to erp5_administration, this is not a "core" feature but just a developer tool. It was used in a few tests, move all the tests in testERP5Administration
-