Commit 1a08981f authored by Fatih Acet's avatar Fatih Acet

Merge branch...

Merge branch '24017-long-build-list-dropdowns-which-scroll-are-not-immediately-obvious' into 'master'

change build list height to show 6,5 builds + improve padding of list, with firs…

## What does this MR do?

lets the builds dropdown in the pipeline graph show only 6,5 builds instead of 7.. so its easier to know if a user can scroll

## Are there points in the code the reviewer needs to double check?

I changed the padding of the list to 0 and gave the 8px top and bottom padding from the `ul` to the `first-child` and `last-child` li elements inside the list. Is that okey. Reason why, is that it breaks the list off correctly at the edges:)

![image](/uploads/f386e550a6044718035065a4ffd1e5a2/image.png) vs ![image](/uploads/4b535816f148771c26f4d4f3937d0305/image.png)




## Why was this MR needed?

easier to let people know when its possible to scroll.. to expect more builds

## Screenshots (if relevant)

![image](/uploads/ecfd34625063f566987a81f0e3f50251/image.png)


## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Closes #24017

See merge request !7210
parents 957744da 2cb7285b
......@@ -71,6 +71,10 @@ entry.
- Removes any symlinks before importing a project export file. CVE-2016-9086
- Fixed Import/Export foreign key issue to do with project members.
- Fix relative links in Markdown wiki when displayed in "Project" tab !7218
- Reduce the overhead to calculate number of open/closed issues and merge requests within the group or project
- Fix project features default values
- Changed build dropdown list length to be 6,5 builds long in the pipeline graph
## 8.13.2 (2016-10-31)
......
......@@ -444,7 +444,7 @@
}
.grouped-pipeline-dropdown {
padding: 8px 0;
padding: 0;
width: 186px;
left: auto;
right: -197px;
......@@ -453,6 +453,14 @@
ul {
max-height: 245px;
overflow: auto;
li:first-child {
padding-top: 8px;
}
li:last-child {
padding-bottom: 8px;
}
}
a {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment