Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
26754e82
Commit
26754e82
authored
Feb 12, 2018
by
André Luís
Committed by
Clement Ho
Feb 12, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean new Flash() and stop disabling no-new (eslint) when possible
parent
07ccc89c
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
7 deletions
+6
-7
app/assets/javascripts/boards/components/board_sidebar.js
app/assets/javascripts/boards/components/board_sidebar.js
+2
-1
app/assets/javascripts/boards/components/modal/footer.js
app/assets/javascripts/boards/components/modal/footer.js
+2
-3
app/assets/javascripts/boards/components/sidebar/remove_issue.js
...ets/javascripts/boards/components/sidebar/remove_issue.js
+2
-3
No files found.
app/assets/javascripts/boards/components/board_sidebar.js
View file @
26754e82
...
@@ -2,6 +2,7 @@
...
@@ -2,6 +2,7 @@
import
Vue
from
'
vue
'
;
import
Vue
from
'
vue
'
;
import
Flash
from
'
../../flash
'
;
import
Flash
from
'
../../flash
'
;
import
{
__
}
from
'
../../locale
'
;
import
Sidebar
from
'
../../right_sidebar
'
;
import
Sidebar
from
'
../../right_sidebar
'
;
import
eventHub
from
'
../../sidebar/event_hub
'
;
import
eventHub
from
'
../../sidebar/event_hub
'
;
import
assigneeTitle
from
'
../../sidebar/components/assignees/assignee_title
'
;
import
assigneeTitle
from
'
../../sidebar/components/assignees/assignee_title
'
;
...
@@ -95,7 +96,7 @@ gl.issueBoards.BoardSidebar = Vue.extend({
...
@@ -95,7 +96,7 @@ gl.issueBoards.BoardSidebar = Vue.extend({
})
})
.
catch
(()
=>
{
.
catch
(()
=>
{
this
.
loadingAssignees
=
false
;
this
.
loadingAssignees
=
false
;
return
new
Flash
(
'
An error occurred while saving assignees
'
);
Flash
(
__
(
'
An error occurred while saving assignees
'
)
);
});
});
},
},
},
},
...
...
app/assets/javascripts/boards/components/modal/footer.js
View file @
26754e82
/* eslint-disable no-new */
import
Vue
from
'
vue
'
;
import
Vue
from
'
vue
'
;
import
Flash
from
'
../../../flash
'
;
import
Flash
from
'
../../../flash
'
;
import
{
__
}
from
'
../../../locale
'
;
import
'
./lists_dropdown
'
;
import
'
./lists_dropdown
'
;
import
{
pluralize
}
from
'
../../../lib/utils/text_utility
'
;
import
{
pluralize
}
from
'
../../../lib/utils/text_utility
'
;
...
@@ -36,7 +35,7 @@ gl.issueBoards.ModalFooter = Vue.extend({
...
@@ -36,7 +35,7 @@ gl.issueBoards.ModalFooter = Vue.extend({
gl
.
boardService
.
bulkUpdate
(
issueIds
,
{
gl
.
boardService
.
bulkUpdate
(
issueIds
,
{
add_label_ids
:
[
list
.
label
.
id
],
add_label_ids
:
[
list
.
label
.
id
],
}).
catch
(()
=>
{
}).
catch
(()
=>
{
new
Flash
(
'
Failed to update issues, please try again.
'
,
'
alert
'
);
Flash
(
__
(
'
Failed to update issues, please try again.
'
)
);
selectedIssues
.
forEach
((
issue
)
=>
{
selectedIssues
.
forEach
((
issue
)
=>
{
list
.
removeIssue
(
issue
);
list
.
removeIssue
(
issue
);
...
...
app/assets/javascripts/boards/components/sidebar/remove_issue.js
View file @
26754e82
/* eslint-disable no-new */
import
Vue
from
'
vue
'
;
import
Vue
from
'
vue
'
;
import
Flash
from
'
../../../flash
'
;
import
Flash
from
'
../../../flash
'
;
import
{
__
}
from
'
../../../locale
'
;
const
Store
=
gl
.
issueBoards
.
BoardsStore
;
const
Store
=
gl
.
issueBoards
.
BoardsStore
;
...
@@ -45,7 +44,7 @@ gl.issueBoards.RemoveIssueBtn = Vue.extend({
...
@@ -45,7 +44,7 @@ gl.issueBoards.RemoveIssueBtn = Vue.extend({
},
},
};
};
Vue
.
http
.
patch
(
this
.
updateUrl
,
data
).
catch
(()
=>
{
Vue
.
http
.
patch
(
this
.
updateUrl
,
data
).
catch
(()
=>
{
new
Flash
(
'
Failed to remove issue from board, please try again.
'
,
'
alert
'
);
Flash
(
__
(
'
Failed to remove issue from board, please try again.
'
)
);
lists
.
forEach
((
list
)
=>
{
lists
.
forEach
((
list
)
=>
{
list
.
addIssue
(
issue
);
list
.
addIssue
(
issue
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment