Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
27471d01
Commit
27471d01
authored
Jul 28, 2016
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don’t depend on unique class.
parent
1c2eefef
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
6 deletions
+6
-6
app/assets/javascripts/diff_notes/components/jump_to_discussion.js.es6
...vascripts/diff_notes/components/jump_to_discussion.js.es6
+1
-1
app/assets/javascripts/diff_notes/services/resolve.js.es6
app/assets/javascripts/diff_notes/services/resolve.js.es6
+4
-4
app/views/discussions/_discussion.html.haml
app/views/discussions/_discussion.html.haml
+1
-1
No files found.
app/assets/javascripts/diff_notes/components/jump_to_discussion.js.es6
View file @
27471d01
...
@@ -56,7 +56,7 @@
...
@@ -56,7 +56,7 @@
}
}
if (nextUnresolvedDiscussionId) {
if (nextUnresolvedDiscussionId) {
$.scrollTo(`.
${nextUnresolvedDiscussionId}
`, {
$.scrollTo(`.
discussion[data-discussion-id="${nextUnresolvedDiscussionId}"]
`, {
offset: -($('.navbar-gitlab').outerHeight() + $('.layout-nav').outerHeight())
offset: -($('.navbar-gitlab').outerHeight() + $('.layout-nav').outerHeight())
});
});
}
}
...
...
app/assets/javascripts/diff_notes/services/resolve.js.es6
View file @
27471d01
...
@@ -83,13 +83,13 @@
...
@@ -83,13 +83,13 @@
}
}
updateUpdatedHtml(discussionId, data) {
updateUpdatedHtml(discussionId, data) {
const $discussionHeadline = $(`.
${discussionId}
.js-discussion-headline`);
const $discussionHeadline = $(`.
discussion[data-discussion-id="${discussionId}"]
.js-discussion-headline`);
if (data.
updated
_html) {
if (data.
discussion_headline
_html) {
if ($discussionHeadline.length) {
if ($discussionHeadline.length) {
$discussionHeadline.replaceWith(data.
updated
_html);
$discussionHeadline.replaceWith(data.
discussion_headline
_html);
} else {
} else {
$(`.
${discussionId} .discussion-header`).append(data.updated
_html);
$(`.
discussion[data-discussion-id="${discussionId}"] .discussion-header`).append(data.discussion_headline
_html);
}
}
} else {
} else {
$discussionHeadline.remove();
$discussionHeadline.remove();
...
...
app/views/discussions/_discussion.html.haml
View file @
27471d01
...
@@ -5,7 +5,7 @@
...
@@ -5,7 +5,7 @@
=
link_to
user_path
(
discussion
.
author
)
do
=
link_to
user_path
(
discussion
.
author
)
do
=
image_tag
avatar_icon
(
discussion
.
author
),
class:
"avatar s40"
=
image_tag
avatar_icon
(
discussion
.
author
),
class:
"avatar s40"
.timeline-content
.timeline-content
.discussion.js-toggle-container
{
class:
discussion
.
id
}
.discussion.js-toggle-container
{
class:
discussion
.
id
,
data:
{
discussion_id:
discussion
.
id
}
}
.discussion-header
.discussion-header
.discussion-actions
.discussion-actions
=
link_to
"#"
,
class:
"note-action-button discussion-toggle-button js-toggle-button"
do
=
link_to
"#"
,
class:
"note-action-button discussion-toggle-button js-toggle-button"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment