Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
30654fc9
Commit
30654fc9
authored
Aug 16, 2016
by
Ahmad Sherif
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Simplify SQL queries of marking a todo as done
parent
1f144951
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
4 deletions
+3
-4
CHANGELOG
CHANGELOG
+1
-0
app/controllers/dashboard/todos_controller.rb
app/controllers/dashboard/todos_controller.rb
+2
-4
No files found.
CHANGELOG
View file @
30654fc9
...
@@ -131,6 +131,7 @@ v 8.11.0 (unreleased)
...
@@ -131,6 +131,7 @@ v 8.11.0 (unreleased)
- Ensure file editing in UI does not overwrite commited changes without warning user
- Ensure file editing in UI does not overwrite commited changes without warning user
- Eliminate unneeded calls to Repository#blob_at when listing commits with no path
- Eliminate unneeded calls to Repository#blob_at when listing commits with no path
- Update gitlab_git gem to 10.4.7
- Update gitlab_git gem to 10.4.7
- Simplify SQL queries of marking a todo as done
v 8.10.6
v 8.10.6
- Upgrade Rails to 4.2.7.1 for security fixes. !5781
- Upgrade Rails to 4.2.7.1 for security fixes. !5781
...
...
app/controllers/dashboard/todos_controller.rb
View file @
30654fc9
...
@@ -6,6 +6,8 @@ class Dashboard::TodosController < Dashboard::ApplicationController
...
@@ -6,6 +6,8 @@ class Dashboard::TodosController < Dashboard::ApplicationController
end
end
def
destroy
def
destroy
todo
=
Todo
.
new
(
id:
params
[
:id
])
TodoService
.
new
.
mark_todos_as_done
([
todo
],
current_user
)
TodoService
.
new
.
mark_todos_as_done
([
todo
],
current_user
)
respond_to
do
|
format
|
respond_to
do
|
format
|
...
@@ -27,10 +29,6 @@ class Dashboard::TodosController < Dashboard::ApplicationController
...
@@ -27,10 +29,6 @@ class Dashboard::TodosController < Dashboard::ApplicationController
private
private
def
todo
@todo
||=
find_todos
.
find
(
params
[
:id
])
end
def
find_todos
def
find_todos
@todos
||=
TodosFinder
.
new
(
current_user
,
params
).
execute
@todos
||=
TodosFinder
.
new
(
current_user
,
params
).
execute
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment