Merge branch 'sh-optimize-mr-api' into 'master'

Remove many N+1 queries with merge requests API

See merge request !12726

app/models/merge_request.rb

@@ -15,7 +15,7 @@ class MergeRequest < ActiveRecord::Base
 
   has_many :merge_request_diffs
   has_one :merge_request_diff,
-    -> { order('merge_request_diffs.id DESC') }
+    -> { order('merge_request_diffs.id DESC') }, inverse_of: :merge_request
 
   belongs_to :head_pipeline, foreign_key: "head_pipeline_id", class_name: "Ci::Pipeline"
 

lib/api/merge_requests.rb

@@ -41,7 +41,9 @@ module API
           args[:milestone_title] = args.delete(:milestone)
           args[:label_name] = args.delete(:labels)
 
-          merge_requests = MergeRequestsFinder.new(current_user, args).execute.inc_notes_with_associations
+          merge_requests = MergeRequestsFinder.new(current_user, args).execute
+                             .inc_notes_with_associations
+                             .preload(:target_project, :author, :assignee, :milestone, :merge_request_diff)
 
           merge_requests.reorder(args[:order_by] => args[:sort])
         end