Commit 4f4060ab authored by Jose Ivan Vargas's avatar Jose Ivan Vargas

Addressed observations

parent f68b3aaa
......@@ -50,13 +50,13 @@ export default class ProtectedBranchCreate {
const $branchInput = this.$form.find('input[name="protected_branch[name]"]');
const $allowedToMergeInput = this.$form.find('input[name="protected_branch[merge_access_levels_attributes][0][access_level]"]');
const $allowedToPushInput = this.$form.find('input[name="protected_branch[push_access_levels_attributes][0][access_level]"]');
const completedForm = !($branchInput.val() && $allowedToMergeInput.length
&& $allowedToPushInput.length);
// Save previously used settings
if (!completedForm) {
this.savePreviousSelection($allowedToMergeInput.val(), $allowedToPushInput.val());
}
const completedForm = !(
$branchInput.val() &&
$allowedToMergeInput.length &&
$allowedToPushInput.length
);
this.savePreviousSelection($allowedToMergeInput.val(), $allowedToPushInput.val());
this.$form.find('input[type="submit"]').attr('disabled', completedForm);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment