Commit 6bab69aa authored by Lin Jen-Shin's avatar Lin Jen-Shin

Show it as successful pipeline, rather than success pipeline

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_16132150
parent 8dd580f4
...@@ -74,4 +74,13 @@ module NotificationsHelper ...@@ -74,4 +74,13 @@ module NotificationsHelper
return unless notification_setting.source_type return unless notification_setting.source_type
hidden_field_tag "#{notification_setting.source_type.downcase}_id", notification_setting.source_id hidden_field_tag "#{notification_setting.source_type.downcase}_id", notification_setting.source_id
end end
def notification_event_name(event)
case event
when :success_pipeline
'Successful pipeline'
else
event.to_s.humanize
end
end
end end
...@@ -27,5 +27,5 @@ ...@@ -27,5 +27,5 @@
%label{ for: field_id } %label{ for: field_id }
= check_box("notification_setting", event, id: field_id, class: "js-custom-notification-event", checked: notification_setting.events[event]) = check_box("notification_setting", event, id: field_id, class: "js-custom-notification-event", checked: notification_setting.events[event])
%strong %strong
= event.to_s.humanize = notification_event_name(event)
= icon("spinner spin", class: "custom-notification-event-loading") = icon("spinner spin", class: "custom-notification-event-loading")
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment