Commit 869de96e authored by Lin Jen-Shin's avatar Lin Jen-Shin

bang to indicate that this method could raise an exception

parent aac297ad
...@@ -40,7 +40,7 @@ module Gitlab ...@@ -40,7 +40,7 @@ module Gitlab
author = sent_notification.recipient author = sent_notification.recipient
project = sent_notification.project project = sent_notification.project
validate_permission(author, project, :create_note) validate_permission!(author, project, :create_note)
raise NoteableNotFoundError unless sent_notification.noteable raise NoteableNotFoundError unless sent_notification.noteable
...@@ -59,7 +59,7 @@ module Gitlab ...@@ -59,7 +59,7 @@ module Gitlab
end end
def process_create_issue def process_create_issue
validate_permission(message_sender, message_project, :create_issue) validate_permission!(message_sender, message_project, :create_issue)
issue = Issues::CreateService.new( issue = Issues::CreateService.new(
message_project, message_project,
...@@ -78,7 +78,7 @@ module Gitlab ...@@ -78,7 +78,7 @@ module Gitlab
end end
end end
def validate_permission(author, project, permission) def validate_permission!(author, project, permission)
raise UserNotFoundError unless author raise UserNotFoundError unless author
raise UserBlockedError if author.blocked? raise UserBlockedError if author.blocked?
# TODO: Give project not found error if author cannot read project # TODO: Give project not found error if author cannot read project
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment