Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
87ff0107
Commit
87ff0107
authored
Mar 31, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Raise one by one instead of if checks
parent
347ee6cc
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
10 deletions
+5
-10
lib/gitlab/email/receiver.rb
lib/gitlab/email/receiver.rb
+5
-10
No files found.
lib/gitlab/email/receiver.rb
View file @
87ff0107
...
...
@@ -76,16 +76,11 @@ module Gitlab
end
def
validate_permission
(
author
,
project
,
permission
)
if
author
if
author
.
blocked?
raise
UserBlockedError
elsif
project
.
nil?
||
!
author
.
can?
(
permission
,
project
)
# TODO: Give project not found error if author cannot read project
raise
UserNotAuthorizedError
end
else
raise
UserNotFoundError
end
raise
UserNotFoundError
unless
author
raise
UserBlockedError
if
author
.
blocked?
# TODO: Give project not found error if author cannot read project
raise
UserNotAuthorizedError
if
project
.
nil?
||
!
author
.
can?
(
permission
,
project
)
end
# Find the first matched user in database from email From: section
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment