Commit 8dfa4101 authored by Robert Speicher's avatar Robert Speicher

Merge branch '25979-fix-todos-on-failed-build' into 'master'

Fix viewing "build failed" TODOs

Closes #25979

See merge request !8262
parents 19b0af4e 22bbb24f
......@@ -35,7 +35,7 @@ module TodosHelper
else
path = [todo.project.namespace.becomes(Namespace), todo.project, todo.target]
path.unshift(:builds) if todo.build_failed?
path.unshift(:pipelines) if todo.build_failed?
polymorphic_path(path, anchor: anchor)
end
......
......@@ -21,6 +21,7 @@ FactoryGirl.define do
trait :build_failed do
action { Todo::BUILD_FAILED }
target factory: :merge_request
end
trait :approval_required do
......
......@@ -155,5 +155,24 @@ describe 'Dashboard Todos', feature: true do
expect(page).to have_selector('.todos-all-done', count: 1)
end
end
context 'User has a Build Failed todo' do
let!(:todo) { create(:todo, :build_failed, user: user, project: project, author: author) }
before do
login_as user
visit dashboard_todos_path
end
it 'shows the todo' do
expect(page).to have_content 'The build failed for your merge request'
end
it 'links to the pipelines for the merge request' do
href = pipelines_namespace_project_merge_request_path(project.namespace, project, todo.target)
expect(page).to have_link "merge request #{todo.target.to_reference}", href
end
end
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment