Commit 96e98632 authored by Timothy Andrew's avatar Timothy Andrew

Implement review comments for !12445 from @jneen.

- Fix duplicate `prevent` declaration
- Add spec for `GlobalPolicy`
parent 5dedea35
...@@ -18,7 +18,6 @@ class GlobalPolicy < BasePolicy ...@@ -18,7 +18,6 @@ class GlobalPolicy < BasePolicy
prevent :receive_notifications prevent :receive_notifications
prevent :use_quick_actions prevent :use_quick_actions
prevent :create_group prevent :create_group
prevent :log_in
end end
rule { default }.policy do rule { default }.policy do
......
require 'spec_helper'
describe GlobalPolicy, models: true do
let(:current_user) { create(:user) }
let(:user) { create(:user) }
subject { GlobalPolicy.new(current_user, [user]) }
describe "reading the list of users" do
context "for a logged in user" do
it { is_expected.to be_allowed(:read_users_list) }
end
context "for an anonymous user" do
let(:current_user) { nil }
context "when the public level is restricted" do
before do
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
end
it { is_expected.not_to be_allowed(:read_users_list) }
end
context "when the public level is not restricted" do
before do
stub_application_setting(restricted_visibility_levels: [])
end
it { is_expected.to be_allowed(:read_users_list) }
end
end
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment