Commit ade61c96 authored by Clement Ho's avatar Clement Ho

Fix error field highlighting

parent 73cd8ed0
...@@ -62,7 +62,7 @@ export default class GlFieldError { ...@@ -62,7 +62,7 @@ export default class GlFieldError {
this.inputDomElement = this.inputElement.get(0); this.inputDomElement = this.inputElement.get(0);
this.form = formErrors; this.form = formErrors;
this.errorMessage = this.inputElement.attr('title') || 'This field is required.'; this.errorMessage = this.inputElement.attr('title') || 'This field is required.';
this.fieldErrorElement = $(`<p class='${errorMessageClass} hide'>${this.errorMessage}</p>`); this.fieldErrorElement = $(`<p class='${errorMessageClass} hidden'>${this.errorMessage}</p>`);
this.state = { this.state = {
valid: false, valid: false,
...@@ -146,8 +146,8 @@ export default class GlFieldError { ...@@ -146,8 +146,8 @@ export default class GlFieldError {
renderInvalid() { renderInvalid() {
this.inputElement.addClass(inputErrorClass); this.inputElement.addClass(inputErrorClass);
this.scopedSiblings.hide(); this.scopedSiblings.addClass('hidden');
return this.fieldErrorElement.show(); return this.fieldErrorElement.removeClass('hidden');
} }
renderClear() { renderClear() {
...@@ -157,7 +157,7 @@ export default class GlFieldError { ...@@ -157,7 +157,7 @@ export default class GlFieldError {
this.accessCurrentValue(trimmedInput); this.accessCurrentValue(trimmedInput);
} }
this.inputElement.removeClass(inputErrorClass); this.inputElement.removeClass(inputErrorClass);
this.scopedSiblings.hide(); this.scopedSiblings.addClass('hidden');
this.fieldErrorElement.hide(); this.fieldErrorElement.addClass('hidden');
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment