fix milestones finder failing spec

b7860b30 · Felipe Artur · 1e81c4be · b7860b30
Commit b7860b30 authored Jul 07, 2017 by Felipe Artur
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

app/finders/milestones_finder.rb app/finders/milestones_finder.rb +2 -1

No files found.
--- a/app/finders/milestones_finder.rb
+++ b/app/finders/milestones_finder.rb
@@ -49,7 +49,8 @@ class MilestonesFinder
    if params.has_key?(:order)
      items.reorder(params[:order])
    else
-      items.reorder('due_date ASC')
+      order_statement = Gitlab::Database.nulls_last_order('due_date', 'ASC')
+      items.reorder(order_statement)
    end
  end
 end