Merge branch 'auth_duplication' into 'master'

Remove unnecessary authorisations Because we already check read_project ability in `before_filter :project` See merge request !1240

Merge branch 'auth_duplication' into 'master'
Remove unnecessary authorisations Because we already check read_project ability in `before_filter :project` See merge request !1240
c3e83d47 · Dmitriy Zaporozhets · f9814bf2 · 6f34d404 · c3e83d47 · c3e83d47
Commit c3e83d47 authored Nov 05, 2014 by Dmitriy Zaporozhets
14 changed files
--- a/app/controllers/projects/base_tree_controller.rb
+++ b/app/controllers/projects/base_tree_controller.rb
 class Projects::BaseTreeController < Projects::ApplicationController
  include ExtractsPath

-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project
 end

--- a/app/controllers/projects/blame_controller.rb
+++ b/app/controllers/projects/blame_controller.rb
@@ -3,7 +3,6 @@ class Projects::BlameController < Projects::ApplicationController
  include ExtractsPath

  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/blob_controller.rb
+++ b/app/controllers/projects/blob_controller.rb
@@ -3,7 +3,6 @@ class Projects::BlobController < Projects::ApplicationController
  include ExtractsPath

  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project
  before_filter :authorize_push_code!, only: [:destroy]

--- a/app/controllers/projects/branches_controller.rb
+++ b/app/controllers/projects/branches_controller.rb
 class Projects::BranchesController < Projects::ApplicationController
  # Authorize
-  before_filter :authorize_read_project!
  before_filter :require_non_empty_project

  before_filter :authorize_download_code!

--- a/app/controllers/projects/commit_controller.rb
+++ b/app/controllers/projects/commit_controller.rb
@@ -3,7 +3,6 @@
 # Not to be confused with CommitsController, plural.
 class Projects::CommitController < Projects::ApplicationController
  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project
  before_filter :commit

--- a/app/controllers/projects/commits_controller.rb
+++ b/app/controllers/projects/commits_controller.rb
@@ -4,7 +4,6 @@ class Projects::CommitsController < Projects::ApplicationController
  include ExtractsPath

  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/compare_controller.rb
+++ b/app/controllers/projects/compare_controller.rb
 class Projects::CompareController < Projects::ApplicationController
  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/graphs_controller.rb
+++ b/app/controllers/projects/graphs_controller.rb
 class Projects::GraphsController < Projects::ApplicationController
  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/network_controller.rb
+++ b/app/controllers/projects/network_controller.rb
@@ -3,7 +3,6 @@ class Projects::NetworkController < Projects::ApplicationController
  include ApplicationHelper

  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/raw_controller.rb
+++ b/app/controllers/projects/raw_controller.rb
@@ -3,7 +3,6 @@ class Projects::RawController < Projects::ApplicationController
  include ExtractsPath

  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/refs_controller.rb
+++ b/app/controllers/projects/refs_controller.rb
@@ -2,7 +2,6 @@ class Projects::RefsController < Projects::ApplicationController
  include ExtractsPath

  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/repositories_controller.rb
+++ b/app/controllers/projects/repositories_controller.rb
 class Projects::RepositoriesController < Projects::ApplicationController
  # Authorize
-  before_filter :authorize_read_project!
  before_filter :authorize_download_code!
  before_filter :require_non_empty_project


--- a/app/controllers/projects/tags_controller.rb
+++ b/app/controllers/projects/tags_controller.rb
 class Projects::TagsController < Projects::ApplicationController
  # Authorize
-  before_filter :authorize_read_project!
  before_filter :require_non_empty_project
-
  before_filter :authorize_download_code!
  before_filter :authorize_push_code!, only: [:create]
  before_filter :authorize_admin_project!, only: [:destroy]

--- a/app/controllers/projects_controller.rb
+++ b/app/controllers/projects_controller.rb
@@ -4,7 +4,6 @@ class ProjectsController < ApplicationController
  before_filter :repository, except: [:new, :create]

  # Authorize
-  before_filter :authorize_read_project!, except: [:index, :new, :create]
  before_filter :authorize_admin_project!, only: [:edit, :update, :destroy, :transfer, :archive, :unarchive, :retry_import]

  layout 'navless', only: [:new, :create, :fork]