Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
d54faf2c
Commit
d54faf2c
authored
Jun 06, 2017
by
Kushal Pandya
Committed by
Phil Hughes
Jun 06, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix missing tooltip and ARIA labels for accessibility
parent
2f02843f
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
7 additions
and
7 deletions
+7
-7
app/views/projects/buttons/_download.html.haml
app/views/projects/buttons/_download.html.haml
+1
-1
app/views/projects/buttons/_dropdown.html.haml
app/views/projects/buttons/_dropdown.html.haml
+1
-1
app/views/projects/buttons/_fork.html.haml
app/views/projects/buttons/_fork.html.haml
+1
-1
app/views/projects/new.html.haml
app/views/projects/new.html.haml
+1
-1
app/views/shared/notifications/_button.html.haml
app/views/shared/notifications/_button.html.haml
+2
-2
features/steps/project/fork.rb
features/steps/project/fork.rb
+1
-1
No files found.
app/views/projects/buttons/_download.html.haml
View file @
d54faf2c
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
-
if
!
project
.
empty_repo?
&&
can?
(
current_user
,
:download_code
,
project
)
-
if
!
project
.
empty_repo?
&&
can?
(
current_user
,
:download_code
,
project
)
.project-action-button.dropdown.inline
>
.project-action-button.dropdown.inline
>
%button
.btn
{
'data-toggle'
=>
'dropdown
'
}
%button
.btn
.has-tooltip
{
title:
'Download'
,
'data-toggle'
=>
'dropdown'
,
'aria-label'
=>
'Download
'
}
=
icon
(
'download'
)
=
icon
(
'download'
)
=
icon
(
"caret-down"
)
=
icon
(
"caret-down"
)
%span
.sr-only
%span
.sr-only
...
...
app/views/projects/buttons/_dropdown.html.haml
View file @
d54faf2c
-
if
current_user
-
if
current_user
.project-action-button.dropdown.inline
.project-action-button.dropdown.inline
%a
.btn.dropdown-toggle
{
href:
'#'
,
"data-toggle"
=>
"dropdown"
}
%a
.btn.dropdown-toggle
.has-tooltip
{
href:
'#'
,
title:
'Create new...'
,
'data-toggle'
=>
'dropdown'
,
'data-container'
=>
'body'
,
'aria-label'
=>
'Create new...'
}
=
icon
(
'plus'
)
=
icon
(
'plus'
)
=
icon
(
"caret-down"
)
=
icon
(
"caret-down"
)
%ul
.dropdown-menu.dropdown-menu-align-right.project-home-dropdown
%ul
.dropdown-menu.dropdown-menu-align-right.project-home-dropdown
...
...
app/views/projects/buttons/_fork.html.haml
View file @
d54faf2c
...
@@ -5,7 +5,7 @@
...
@@ -5,7 +5,7 @@
=
custom_icon
(
'icon_fork'
)
=
custom_icon
(
'icon_fork'
)
%span
Fork
%span
Fork
-
else
-
else
=
link_to
new_namespace_project_fork_path
(
@project
.
namespace
,
@project
),
title:
'Fork project'
,
class:
'btn'
do
=
link_to
new_namespace_project_fork_path
(
@project
.
namespace
,
@project
),
class:
'btn'
do
=
custom_icon
(
'icon_fork'
)
=
custom_icon
(
'icon_fork'
)
%span
Fork
%span
Fork
.count-with-arrow
.count-with-arrow
...
...
app/views/projects/new.html.haml
View file @
d54faf2c
...
@@ -95,7 +95,7 @@
...
@@ -95,7 +95,7 @@
.form-group.project-visibility-level-holder
.form-group.project-visibility-level-holder
=
f
.
label
:visibility_level
,
class:
'label-light'
do
=
f
.
label
:visibility_level
,
class:
'label-light'
do
Visibility Level
Visibility Level
=
link_to
icon
(
'question-circle'
),
help_page_path
(
"public_access/public_access"
)
=
link_to
icon
(
'question-circle'
),
help_page_path
(
"public_access/public_access"
)
,
aria:
{
label:
'Documentation for Visibility Level'
}
=
render
'shared/visibility_level'
,
f:
f
,
visibility_level:
visibility_level
.
to_i
,
can_change_visibility_level:
true
,
form_model:
@project
,
with_label:
false
=
render
'shared/visibility_level'
,
f:
f
,
visibility_level:
visibility_level
.
to_i
,
can_change_visibility_level:
true
,
form_model:
@project
,
with_label:
false
=
f
.
submit
'Create project'
,
class:
"btn btn-create project-submit"
,
tabindex:
4
=
f
.
submit
'Create project'
,
class:
"btn btn-create project-submit"
,
tabindex:
4
...
...
app/views/shared/notifications/_button.html.haml
View file @
d54faf2c
...
@@ -6,14 +6,14 @@
...
@@ -6,14 +6,14 @@
.js-notification-toggle-btns
.js-notification-toggle-btns
%div
{
class:
(
"btn-group"
if
notification_setting
.
custom?
)
}
%div
{
class:
(
"btn-group"
if
notification_setting
.
custom?
)
}
-
if
notification_setting
.
custom?
-
if
notification_setting
.
custom?
%button
.dropdown-new.btn.btn-default.
notifications-btn
#notifications-button
{
type:
"button"
,
data:
{
toggle:
"modal"
,
target:
"#"
+
notifications_menu_identifier
(
"modal"
,
notification_setting
)
}
}
%button
.dropdown-new.btn.btn-default.
has-tooltip.notifications-btn
#notifications-button
{
type:
"button"
,
title:
"Notification setting"
,
"aria-label"
=>
"Notification setting: #{notification_title(notification_setting.level)}"
,
data:
{
container:
"body"
,
toggle:
"modal"
,
target:
"#"
+
notifications_menu_identifier
(
"modal"
,
notification_setting
)
}
}
=
icon
(
"bell"
,
class:
"js-notification-loading"
)
=
icon
(
"bell"
,
class:
"js-notification-loading"
)
=
notification_title
(
notification_setting
.
level
)
=
notification_title
(
notification_setting
.
level
)
%button
.btn.dropdown-toggle
{
data:
{
toggle:
"dropdown"
,
target:
notifications_menu_identifier
(
"dropdown"
,
notification_setting
)
}
}
%button
.btn.dropdown-toggle
{
data:
{
toggle:
"dropdown"
,
target:
notifications_menu_identifier
(
"dropdown"
,
notification_setting
)
}
}
=
icon
(
'caret-down'
)
=
icon
(
'caret-down'
)
.sr-only
Toggle dropdown
.sr-only
Toggle dropdown
-
else
-
else
%button
.dropdown-new.btn.btn-default.
notifications-btn
#notifications-button
{
type:
"button"
,
data:
{
toggle:
"dropdown"
,
target:
notifications_menu_identifier
(
"dropdown"
,
notification_setting
)
}
}
%button
.dropdown-new.btn.btn-default.
has-tooltip.notifications-btn
#notifications-button
{
type:
"button"
,
title:
"Notification setting"
,
"aria-label"
=>
"Notification setting: #{notification_title(notification_setting.level)}"
,
data:
{
container:
"body"
,
toggle:
"dropdown"
,
target:
notifications_menu_identifier
(
"dropdown"
,
notification_setting
)
}
}
=
icon
(
"bell"
,
class:
"js-notification-loading"
)
=
icon
(
"bell"
,
class:
"js-notification-loading"
)
=
notification_title
(
notification_setting
.
level
)
=
notification_title
(
notification_setting
.
level
)
=
icon
(
"caret-down"
)
=
icon
(
"caret-down"
)
...
...
features/steps/project/fork.rb
View file @
d54faf2c
...
@@ -5,7 +5,7 @@ class Spinach::Features::ProjectFork < Spinach::FeatureSteps
...
@@ -5,7 +5,7 @@ class Spinach::Features::ProjectFork < Spinach::FeatureSteps
step
'I click link "Fork"'
do
step
'I click link "Fork"'
do
expect
(
page
).
to
have_content
"Shop"
expect
(
page
).
to
have_content
"Shop"
click_link
"Fork
project
"
click_link
"Fork"
end
end
step
'I am a member of project "Shop"'
do
step
'I am a member of project "Shop"'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment