Commit f162dde6 authored by Luke Bennett's avatar Luke Bennett

Now anchors to the top or bottom of the build trace with the correct offset

parent b5d74bef
......@@ -27,7 +27,7 @@
$(document).off('click', '.js-sidebar-build-toggle').on('click', '.js-sidebar-build-toggle', this.toggleSidebar);
$(window).off('resize.build').on('resize.build', this.hideSidebar);
$(document).off('click', '.stage-item').on('click', '.stage-item', this.updateDropdown);
$('.step-up-trace, .step-down-trace').off('click').on('click', this.stepTrace);
$('#js-build-scroll > a').off('click').on('click', this.stepTrace);
this.updateArtifactRemoveDate();
if ($('#build-trace').length) {
this.getInitialBuildTrace();
......@@ -167,11 +167,11 @@
};
Build.prototype.stepTrace = function(e) {
if ($(e.currentTarget).hasClass('step-up-trace')) {
$.scrollTo('-=50px');
} else {
$.scrollTo('+=50px');
}
e.preventDefault();
$currentTarget = $(e.currentTarget);
$.scrollTo($currentTarget.attr('href'), {
offset: -($('.navbar-gitlab').outerHeight() + $('.layout-nav').outerHeight())
});
};
return Build;
......
......@@ -34,9 +34,9 @@
Build has been erased #{erased_by.html_safe} #{time_ago_with_tooltip(@build.erased_at)}
- else
#js-build-scroll.scroll-controls
%a.step-up-trace.btn
= link_to '#build-trace', class: 'btn' do
%i.fa.fa-angle-up
%a.step-down-trace.btn
= link_to '#down-build-trace', class: 'btn' do
%i.fa.fa-angle-down
%pre.build-trace#build-trace
%code.bash.js-build-output
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment