Merge branch 'dz-jupyter-use-nip-io' into 'master'

Use nip.io instead of xip.io for jupyter domain suggestion

See merge request gitlab-org/gitlab-ce!19576
parents f646a8b9 a9043149
...@@ -95,7 +95,7 @@ export default class ClusterStore { ...@@ -95,7 +95,7 @@ export default class ClusterStore {
this.state.applications.jupyter.hostname = this.state.applications.jupyter.hostname =
serverAppEntry.hostname || serverAppEntry.hostname ||
(this.state.applications.ingress.externalIp (this.state.applications.ingress.externalIp
? `jupyter.${this.state.applications.ingress.externalIp}.xip.io` ? `jupyter.${this.state.applications.ingress.externalIp}.nip.io`
: ''); : '');
} }
}); });
......
...@@ -110,7 +110,7 @@ describe('Clusters Store', () => { ...@@ -110,7 +110,7 @@ describe('Clusters Store', () => {
expect( expect(
store.state.applications.jupyter.hostname, store.state.applications.jupyter.hostname,
).toEqual(`jupyter.${store.state.applications.ingress.externalIp}.xip.io`); ).toEqual(`jupyter.${store.state.applications.ingress.externalIp}.nip.io`);
}); });
}); });
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment