Commit fd4728a5 authored by Sean McGivern's avatar Sean McGivern

Merge branch 'ce-port-ee-f531c07299' into 'master'

Fix a too strict array-matching expectation

See merge request gitlab-org/gitlab-ce!17093
parents 7294bc80 539b3a35
...@@ -81,7 +81,7 @@ describe 'OpenID Connect requests' do ...@@ -81,7 +81,7 @@ describe 'OpenID Connect requests' do
it 'includes all user information and group memberships' do it 'includes all user information and group memberships' do
request_user_info request_user_info
expect(json_response).to eq({ expect(json_response).to match(a_hash_including({
'sub' => hashed_subject, 'sub' => hashed_subject,
'name' => 'Alice', 'name' => 'Alice',
'nickname' => 'alice', 'nickname' => 'alice',
...@@ -90,13 +90,12 @@ describe 'OpenID Connect requests' do ...@@ -90,13 +90,12 @@ describe 'OpenID Connect requests' do
'website' => 'https://example.com', 'website' => 'https://example.com',
'profile' => 'http://localhost/alice', 'profile' => 'http://localhost/alice',
'picture' => "http://localhost/uploads/-/system/user/avatar/#{user.id}/dk.png", 'picture' => "http://localhost/uploads/-/system/user/avatar/#{user.id}/dk.png",
'groups' => 'groups' => anything
if Group.supports_nested_groups? }))
['group1', 'group2/group3', 'group2/group3/group4']
else expected_groups = %w[group1 group2/group3]
['group1', 'group2/group3'] expected_groups << 'group2/group3/group4' if Group.supports_nested_groups?
end expect(json_response['groups']).to match_array(expected_groups)
})
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment