So we don't have to do it in CreateDeploymentService
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11695#note_31322649

* upstream/master: (39 commits)
  Resolve "Improve Container Registry description"
  Add username parameter to gravatar URL
  Fix replying to a commit discussion displayed in the context of an MR
  Add fog-aliyun as backup storage provider
  Add missing specs
  Make sure protected can't be null; Test protected!
  Update session cookie key name to be unique to instance in development
  Just mention which GitLab version is required
  Fix data inconsistency issue for old artifacts by moving them to a currently used path
  Fix N+1 queries for non-members in comment threads
  Fix rubocop in spec/helpers/diff_helper_spec.rb
  Merge two items into one in the doc
  Only remove FK if it exists
  Maintain notes avatar at smaller breakpoint
  Fix pipeline schedule value name in documentation
  Add test for Project#protected_for?
  Update diff discussion position per discussion instead of per note
  Display Shared Runner status in Admin Dashboard
  Make sure we're loading the fresh variables
  Now secret_variables_for would return the variables
  ...

it a bit more robust against missing options,
which we did guard on for some cases.

Maintain notes avatar at smaller breakpoint

Closes #32985

See merge request !11841

Add fog-aliyun as backup storage provider

See merge request !11849

Add username parameter to gravatar URL

Closes #24472

See merge request !11741

Implementation for protected variables

Closes #24196

See merge request !11688

Resolve "Improve Container Registry description"

Closes #30651

See merge request !11816

Fix replying to a commit discussion displayed in the context of an MR

Closes #33201

See merge request !11847

Fix title of discussion jump button at top of page

See merge request !11768

Fix data inconsistency issue for old artifacts by moving them to a currently used path

Closes #32036

See merge request !11824

Update session cookie key name to be unique to instance in development

Closes #31644

See merge request !11839

To make sure that we're accessing the same instance, so ending up
with `env.external` = `env.external_url` shall be fine.

Update diff discussion position per discussion instead of per note

Closes #33157

See merge request !11833

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/31644

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11688/diffs#note_31277454

Add missing `can_push` parameter to POST /v3/deploy_keys

See merge request !11607

Document not using ActiveRecord's serialize method

See merge request !11821

methods directly from job, avoid duplicating the works.

Fix N+1 queries for non-members in comment threads

See merge request !11827

to the external_url from persisted environment,
and make the other utility methods private as
we don't really need to use them outside of the job.

Only remove FK if it exists

See merge request !11828

Display Shared Runner status in Admin Dashboard

Closes #31602

See merge request !11783

Fix: A diff comment on a change at last line of a file shows as two comments in discussion

Closes #32353

See merge request !11802

Fix pipeline schedule value name in documentation, fixes #33142

Closes #33142

See merge request !11840

* upstream/master: (251 commits)
  Don't match email addresses or foo@bar as user references
  Revert "Update GITLAB_SHELL_VERSION"
  Update GITLAB_SHELL_VERSION
  Add feature toggles through Flipper
  Change no_limits to limits
  Move includes call to scope
  Add GitLab Resources to University
  Add Documentation for GIT_CHECKOUT variable
  Remove entry variable
  Do not try to preload Commits when using Note.includes(:noteable)
  Ui improvements for count badges and permission badges
  Rename the other jobs
  Update jobs_spec for changes from builds_spec
  Introduce source to pipeline entity
  Update docs related to protected actions
  Add changelog for protected branches abilities fix
  Ask for an example project for bug reports
  Center loading spinner in issuable filters
  Fix chat commands specs related to protected actions
  Fix builds controller specs related to protected actions
  ...

Fixes multi-line math in notebooks

Closes #30900 and #33074

See merge request !11789