An error occurred fetching the project authors.
- 29 Jul, 2016 1 commit
-
-
Yorick Peterse authored
The method Ability.issues_readable_by_user takes a list of users and an optional user and returns an Array of issues readable by said user. This method in turn is used by Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this method no longer needs to get all the available abilities just to check if a user has the "read_issue" ability. To test this I benchmarked an issue with 222 comments on my development environment. Using these changes the time spent in nodes_visible_to_user was reduced from around 120 ms to around 40 ms.
-
- 20 Jul, 2016 1 commit
-
-
Alejandro Rodríguez authored
Currently, even when searching for all authorized issues of *one* project, we run the `Users#authorized_projects` query (which can be rather slow). This update checks if we are handling issues of just one project and does the authorization check locally. It does have the downside of basically repeating the logic of `Users#authorized_projects` on `Project#authorized_for_user`.
-
- 03 Jun, 2016 2 commits
-
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 02 Jun, 2016 1 commit
-
-
Josh Frye authored
-
- 01 Jun, 2016 1 commit
-
-
Yorick Peterse authored
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
-
- 24 May, 2016 1 commit
-
-
Robert Speicher authored
Also removes the note from the development/testing.md guide
-
- 09 May, 2016 1 commit
-
-
Jeroen van Baarsen authored
In 8278b763 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
-
- 19 Apr, 2016 1 commit
-
-
Timothy Andrew authored
-
- 15 Apr, 2016 1 commit
-
-
Timothy Andrew authored
-
- 14 Apr, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 13 Apr, 2016 1 commit
-
-
Timothy Andrew authored
-
- 12 Apr, 2016 3 commits
-
-
Timothy Andrew authored
-
Timothy Andrew authored
- Test the case where we have a referenced merge request that's being - excluded as a "related branch" - This took a while to figure out, especially the `create_cross_references!` line.
-
Timothy Andrew authored
- Previously, the controller held the logic to calculate related branches, which was: `<branches ending with `issue.iid`> - <branches with a merge request referenced in the current issue>` - This logic belongs in the `related_branches` method, not in the controller. This commit makes this change. - This means that `Issue#related_branches` now needs to take a `User`. When we find the branches that have a merge request referenced in the current issue, this is limited to merge requests that the current user has access to. - This is not directly related to #14566, but is a related refactoring.
-
- 23 Mar, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 19 Mar, 2016 2 commits
-
-
Yorick Peterse authored
Requesting the branch names of a repository works even when it's empty, thus there's no need to explicitly check for an empty repository. Removing this check cuts down the amount of Git operations which in turn cuts down request timings a bit. The regular expression used to compare branches was also moved out of the loop so it's created only once.
-
Zeger-Jan van de Weg authored
-
- 18 Mar, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
Given the branch name 'mep-mep' with an iid being 1, the current way, master's way, would yield a branch name of 1-mep-mep. The problem for larger projects however would be that a developer might forget what iid the issue was. When this developer would try to tab complete it would: - Or result in 20+ branches possibly - Or start with the wrong digit, try again with digit++ - Would see 20 branches, repeat Thus the obvious way of solving this is letting the dev tab complete on the issue title, which is easier to remember.
-
- 17 Mar, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 15 Mar, 2016 3 commits
-
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
- 10 Mar, 2016 1 commit
-
-
Yorick Peterse authored
-
- 09 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 16 Oct, 2015 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 12 Oct, 2015 1 commit
-
-
Douwe Maan authored
-
- 06 Sep, 2015 1 commit
-
-
Stan Hu authored
-
- 22 Jun, 2015 1 commit
-
-
Robert Speicher authored
-
- 26 May, 2015 2 commits
-
-
Robert Speicher authored
Snippet model was missing project association
-
Robert Speicher authored
Now there is a single source of information for which attribute a model uses to be referenced, and its special character.
-
- 16 Apr, 2015 1 commit
-
-
Robert Speicher authored
-
- 12 Feb, 2015 1 commit
-
-
Jeroen van Baarsen authored
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
-
- 06 Oct, 2014 1 commit
-
-
Vinnie Okada authored
Add tests for the new task list functionality in the Markdown parser and in issues and merge requests.
-
- 26 Jun, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 09 Apr, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 25 Aug, 2013 1 commit
-
-
ash wilson authored
Any mention of Issues, MergeRequests, or Commits via GitLab-flavored markdown references in descriptions, titles, or attached Notes creates a back-reference Note that links to the original referencer. Furthermore, pushing commits with commit messages that match a (configurable) regexp to a project's default branch will close any issues mentioned by GFM in the matched closing phrase. If accepting a merge request would close any Issues in this way, a banner is appended to the merge request's main panel to indicate this.
-
- 21 Aug, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 29 Jul, 2013 1 commit
-
-
Johannes Schleifenbaum authored
-
- 19 Jun, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-