1. 21 Sep, 2016 22 commits
    • Fatih Acet's avatar
      Merge branch 'shrink-profile-info' into 'master' · 67b6dad3
      Fatih Acet authored
      Shrink profile info
      
      ## What does this MR do?
      Updates design of profile page to match comps
      
      ## Screenshots (if relevant)
      ![Screen_Shot_2016-09-16_at_11.34.21_AM](/uploads/5c2f510e6cc64bf466309db8ec02b9e0/Screen_Shot_2016-09-16_at_11.34.21_AM.png)
      ![Screen_Shot_2016-09-16_at_11.35.20_AM](/uploads/ebd3471965340fce5a897dcfc1a5385c/Screen_Shot_2016-09-16_at_11.35.20_AM.png)
      
      ## Does this MR meet the acceptance criteria?
      
      - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
      - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
      - [ ] API support added
      - Tests
        - [ ] Added for this feature/bug
        - [ ] All builds are passing
      - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
      - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
      - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
      - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
      
      ## What are the relevant issue numbers?
      closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18071
      
      See merge request !6394
      67b6dad3
    • Rémy Coutable's avatar
      Merge branch 'show-all-pipelines-from-all-diffs' into 'master' · 529b17d1
      Rémy Coutable authored
      Show all pipelines from all merge_request_diffs
      
      This way we could also show pipelines from commits which
      were discarded due to a force push.
      
      Closes #21889
      
      See merge request !6414
      529b17d1
    • Rémy Coutable's avatar
      Merge branch 'limit-number-of-shown-environments' into 'master' · 78636703
      Rémy Coutable authored
      Limit number of shown environments
      
      ## What does this MR do?
      
      This MR limits in context of Merge Request a list of shown environments. Previously we would show all environments containing the SHA of the head commit of Merge Request. However, with introducing of dynamically created environments this lead to a cases that we would show multiple review apps, for different branches, because these branches would contain a new questioned commit.
      
      This MR changes what environments we test against presence of the commit, to:
      1. We look for environments with deployments to source_branch of source_project: used for deployments to per-branch environments,
      2. We look for environments with deployments to target_branch of target_project: used for deployments to staging / production environments,
      3. We look for environments with deployments for tags on target_project: used for staging / production environments.
      
      ## Why was this MR needed?
      
      To improve a list of returned environments when we introduced ability to create dynamic environments for review apps:
      https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6323
      
      See merge request !6438
      78636703
    • Jacob Schatz's avatar
      Merge branch '20310-new-project-btn' into 'master' · fb7927db
      Jacob Schatz authored
      Fix new project button alignment
      
      ## What does this MR do?
      Increases the width of the button/search container to fit all items at smaller screen width. The left side of the row can only have a max of two tabs (All Projects, Shared Projects), so everything can still fit on one line until they resize for mobile
      
      ## Why was this MR needed?
      The `New project` button wrapped to next line at smaller screen width, breaking the layout
      
      ## Screenshots (if relevant)
      ![Screen_Shot_2016-09-09_at_11.44.27_AM](/uploads/a726208deec6623d9fb62db0a549bf38/Screen_Shot_2016-09-09_at_11.44.27_AM.png)
      ![Screen_Shot_2016-09-09_at_11.46.29_AM](/uploads/bd8dc911757b14c5fafc4d3849e0b242/Screen_Shot_2016-09-09_at_11.46.29_AM.png)
      
      ## What are the relevant issue numbers?
      Closes #20310
      
      See merge request !6286
      fb7927db
    • Kamil Trzcinski's avatar
      Scope environments to project · 94105993
      Kamil Trzcinski authored
      94105993
    • Kamil Trzcinski's avatar
      Improve specs · 29a64950
      Kamil Trzcinski authored
      29a64950
    • Rémy Coutable's avatar
      870324b5
    • Rémy Coutable's avatar
    • Vitaly Baev's avatar
    • Kamil Trzcinski's avatar
      630b666c
    • Rémy Coutable's avatar
      Merge branch 'add_spec_for_committer_hash' into 'master' · a25ac8a8
      Rémy Coutable authored
      Add spec covering 'committer_hash'
      
      Adds a missing spec from changes added in !5822
      
      See merge request !6433
      a25ac8a8
    • Douwe Maan's avatar
      Merge branch 'bump-shell-to-3-6-0' into 'master' · dd12ffc0
      Douwe Maan authored
      Bump GITLAB_SHELL_VERSION to 3.6.0 for SSH support for LFS.
      
      cc @rdavila
      
      See merge request !6441
      dd12ffc0
    • Kamil Trzcinski's avatar
    • Dmitriy Zaporozhets's avatar
    • Rémy Coutable's avatar
      Merge branch 'post-merge-improve-of-ci-permissions' into 'master' · 6df3dd9d
      Rémy Coutable authored
      Post-merge improve of CI permissions
      
      Improves code from !6409
      
      See merge request !6432
      6df3dd9d
    • Kamil Trzcinski's avatar
      Limit number of shown environments for Merge Requests · d891051c
      Kamil Trzcinski authored
      - For target project show only environments for target branch or with tags
      - For source project show only environments for source branch
      d891051c
    • Robert Speicher's avatar
      Merge branch 'cs-upgrade-sidekiq' into 'master' · 49405ac7
      Robert Speicher authored
      Upgrade Sidekiq to 4.2.1, remove dependency on Sinatra
      
      This updates Sidekiq to 4.2.1, which adds full support for Rails 5 by removing a dependency on Sinatra which was one of the remaining Rails 5 blockers.
      
      Major things to check: Sidekiq still works, obviously. Also that the Web UI/Admin dashboard works and doesn't lose any functionality (based on my testing it works fine).
      
      Working toward #14286.
      
      Changelog: https://github.com/mperham/sidekiq/blob/921e939f995fbb5238975d4121d728b95be99ab5/Changes.md#421
      
      See merge request !6349
      49405ac7
    • Stan Hu's avatar
      Merge branch '21170-cycle-analytics' into 'master' · 5416ab8a
      Stan Hu authored
      Cycle Analytics: first iteration
      
      ## What does this MR do?
      
      - Implement the first iteration of the "Cycle Analytics" feature.
      
      ## What are the relevant issue numbers?
      
      - Closes #21170 
      
      ## Screenshots
      
      ![cycle_analytics_screencast.gif](/uploads/d23c3c912caa6935fd47b53ca3a56b97/cycle_analytics.gif)
      
      ## Backend Tasks
      
      - [x]  Implementation
          - [x]  Phases
              - [x]  Issue (Tracker)
              - [x]  Plan (Board)
              - [x]  Code (IDE)
              - [x]  Test (CI)
              - [x]  Review (MR)
              - [x]  Staging (CD)
              - [x]  Production (Total)
          - [x]  Make heuristics more modular
          - [x]  Scope to project
          - [x]  Date range (30 days, 90 days)
          - [x]  Access restriction
      - [x]  Test
          - [x]  Find a better way to test these phases
          - [x]  Phases
              - [x]  Issue (Tracker)
              - [x]  Plan (Board)
              - [x]  Code (IDE)
              - [x]  Test (CI)
              - [x]  Review (MR)
              - [x]  Staging (CD)
              - [x]  Production (Total)
          - [x]  Test for "end case happens before start case"
          - [x]  Consolidate helper
      - [x]  Miniboss review
      - [x]  Performance testing with mock data
      - [x]  Improve performance
          - [x]  Pre-calculate "merge requests closing issues
          - [x]  Pre-calculate everything else
      - [x]  Test performance against 10k issues
      - [x]  Test all pre-calculation code
          - [x]  Ci::Pipeline -> build start/finish
          - [x]  Ci::Pipeline#merge_requests
          - [x]  Issue -> record default metrics after save
          - [x]  MergeRequest -> record default metrics after save
          - [x]  Deployment -> Update "first_deployed_to_production_at" for MR metrics
          - [x]  Git Push -> Update "first commit mention" for issue metrics
          - [x]  Merge request create/update/refresh -> Update "merge requests closing issues"
      - [x]  Remove `MergeRequestsClosingIssues` when necessary
      - [x]  Changes to unblock Fatih
          - [x]  Add summary data
          - [x]  `stats` should be array
          - [x]  Let `stats` be `null` if all `stats` are null
      - [x]  Indexes for "merge requests closing issues"
      - [x]  Test summary data
      - [x]  Scope everything to project
          - [x]  Find out why tests were passing
      - [x]  Filter should include issues/MRs which have made it to production within the range
      - [x]  Don't create duplicate `MergeRequestsClosingIssues`
      - [x]  Fix tests
      - [x]  MySQL median
      - [x]  Assign to Douwe for review
      - [x]  Fix conflicts
      - [x]  Implement suggestions from Yorick's review
          - [x]  Test on PG
          - [x]  Test on MySQL
      - [x]  Refactor
          - [x]  Cleanup
              - [x]  What happens if we have no data at all?
              - [x]  Extract common queries to methods / scopes
          - [x]  Remove unused queries
          - [x]  Downtime for foreign key migrations
          - [x]  Find a way around "if issue.metrics.present?" all over the place
          - [x]  Find a way around "if merge_request.metrics.present?" all over the place
          - [x]  Test migrations on a fresh database
              - [x]  MySQL
              - [x]  Pg
      - [x]  Access issues
          - While the project is public and the visibility is set to "Everyone with access", you cannot visit the cycle analytics page when signed out.
      - [x]  CHANGELOG
      - [x]  Implement suggestions from Douwe's review
          - [x]  First set of comments
          - [x]  Second set of comments
          - [x]  Third set of comments
          - [x]  Fourth set of comments
      - [x]  Make sure build is green
      - [ ]  Make issue for "polish"
      - [ ]  EE MR
      
      
      See merge request !5986
      5416ab8a
    • Timothy Andrew's avatar
      Implement fourth round of comments from @DouweM. · 244ec0a8
      Timothy Andrew authored
      - Pluralize summary titles
      - Remove the `run_query` method - always return sql strings from the
        `date_time_sql` methods
      244ec0a8
    • Timothy Andrew's avatar
      Fix `CreateDeploymentService` spec. · cc3adcd4
      Timothy Andrew authored
      1. The spec tests that if:
      
        - The merge request is merged
        - The target branch is deployed to production
        - The `first_deployed_to_production_at` metric is `nil` (for some reason)
        - The target branch is deployed to production again
        - The `first_deployed_to_production_at` metric stays as `nil` (and is
          not overwritten).
      
      2. Failure only on MySQL due to some datetime weirdness.
      cc3adcd4
    • Stan Hu's avatar
    • Patricio Cano's avatar
  2. 20 Sep, 2016 18 commits