- 12 May, 2016 7 commits
-
-
Rémy Coutable authored
Group commits by date in server timezone `Time#to_date` just takes the (timezone-less) year, date, and month, and creates a new date from that. Because the commits in the list are grouped by date, rather than chunked when the date changes, a commit can be shown in the wrong order if its CommitDate has a timezone-less date that's different to other commits around it. Convert all CommitDates to the server timezone before grouping, as that will at least produce consistent results. Users can still see a timestamp on the commit that doesn't match the date it's grouped under, because the timestamp shown uses the user's local timezone, and the grouping uses the server's timezone, but that was an issue anyway. ### Before ![image](/uploads/1ffe0e2f86e03590cb96126d4f340436/image.png) ### After ![image](/uploads/b1be1b08782385d13c56528242a5829b/image.png) Closes #3870 and closes #17300. See merge request !4052
-
Marin Jankovski authored
Update cas.md to reflect the current syntax, and added that gitlab-ctl reconfigure should be run. I spent a while trying to figure our why the cas wasn't working! Someone may need to update the source code section of the wiki See merge request !3850
-
Yorick Peterse authored
Update 8.8 guides See merge request !4119
-
Rémy Coutable authored
Relative Links in the Wiki Are Broken - [ ] #16568 (!4050) Relative links in wiki are broken - [x] Investigate issue - [x] Implementation / Fix - [x] Write (failing) tests for `WikiLinkFilter` - [x] Link to `./bar` should either get rewritten correctly or left alone - [x] Link to `./bar.md` should maybe get rewritten correctly (is left alone currently) - [x] Link to `bar.md` should get rewritten correctly - [x] Check if this indeed a bug - [x] Make sure CI is green - [x] Assign to endboss - [x] Wait for review - [x] Implement review feedback - [ ] Wait for merge See merge request !4050
-
Timothy Andrew authored
-
Timothy Andrew authored
- Separate 'exercise' and 'verify' steps of tests. - Use `build_stubbed` instead of `build`
-
Timothy Andrew authored
- And fix behavior for non-file hierarchical links.
-
- 11 May, 2016 25 commits
-
-
Douwe Maan authored
Add snippet tab under user profile Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15572 See merge request !4001
-
Douwe Maan authored
Remove unused `icon_for_event` helper Extracted from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4090 See merge request !4120
-
Robert Speicher authored
-
Jacob Schatz authored
Don't show the Todo count if there aren't any Todos. When there are 0 Todos, the Todos icon still had the blue badge with a "0" in it, which made me think I had a new Todo left. This makes it less annoying. Follow-up on !4077. **Before:** ![Screen_Shot_2016-05-10_at_9.36.57_PM](/uploads/e0dfafae01692286096606c3251f0997/Screen_Shot_2016-05-10_at_9.36.57_PM.png) **After:** ![Screen_Shot_2016-05-10_at_10.01.02_PM](/uploads/30a8bafe8f54862418eb4045e5777a9a/Screen_Shot_2016-05-10_at_10.01.02_PM.png) cc: @jschatz1 @rspeicher See merge request !4113
-
Robert Speicher authored
Improve documentation and web test for web hooks Tips and documentation of actual hook behavior. Improved user feedback when testing hooks via the web UI. See merge request !4015
-
Valery Sizov authored
-
Robert Speicher authored
Remove Rails monkey-patches now that we're using Rails 4.2.6 Closes #17356. See merge request !4115
-
Robert Speicher authored
Improve log message when a project is destroyed to include the namespace See merge request !4114
-
Robert Speicher authored
Restrict starred projects to viewable ones `User#starred_projects` doesn't perform any visibility checks. This has a couple of problems: 1. It assumes a user can always view all of their starred projects in perpetuity (project not changed to private, access revoked, etc.). 2. It assumes that we'll only ever allow a user to star a project they can view. This is currently the case, but bugs happen. Add `User#viewable_starred_projects` to filter the starred projects by those the user either has explicit access to, or are public or internal. Then use that in all places where we list the user's starred projects. Closes #17249. See merge request !4108
-
Robert Speicher authored
Only generate repository push email once The repository push email can be very expensive to generate, especially with syntax-highlighted diffs. Instead of generating the email for each recipient, generate one email object and reset the Message-Id and To headers for each recipient. (Cloning would also be expensive in the case of large emails, although probably not as bad as generating from scratch.) Closes #17270. See merge request !4070
-
Yorick Peterse authored
Updated 8.7.4 CHANGELOG entries See merge request !4116
-
Yorick Peterse authored
[ci skip]
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Sean McGivern authored
`Time#to_date` just takes the (timezone-less) year, date, and month, and creates a new date from that. Because the commits in the list are grouped by date, rather than chunked when the date changes, a commit can be shown in the wrong order if its CommitDate has a timezone-less date that's different to other commits around it. Convert all CommitDates to the server timezone before grouping, as that will at least produce consistent results. Users can still see a timestamp on the commit that doesn't match the date it's grouped under, because the timestamp shown uses the user's local timezone, and the grouping uses the server's timezone, but that was an issue anyway.
-
Rémy Coutable authored
Enable Rubocop Casecmp Performance Cop. Also fixes the errors caused by enabling the cop. `casecmp` is more performant than `.downcase` and `==`. See also: https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/performance/casecmp.rb See merge request !3957
-
Rémy Coutable authored
Enable the StringReplacement cop. Also fix one use of `gsub` that would be faster as `delete`. Use `tr` instead of `gsub` when you are replacing the same number of characters. Use `delete` instead of `gsub` when you are deleting characters. See merge request !3960
-
Sean McGivern authored
The repository push email can be very expensive to generate, especially with syntax-highlighted diffs. Instead of generating the email for each recipient, generate one email object and reset the Message-Id and To headers for each recipient. (Cloning would also be expensive in the case of large emails, although probably not as bad as generating from scratch.)
-
Sean McGivern authored
-
Stan Hu authored
-
Connor Shea authored
When there are 0 Todos, the Todos icon still had the blue badge with a "0" in it, which made me think I had a new Todo left. This makes it less annoying. Follow-up on !4077.
-
Jacob Schatz authored
Removes jquery-scrollto-rails. Instead the script is now included directly from the vendor directory. Resolves #17166. Working towards #14286 and merging !3775. The gem was on 1.4.3.1, here's the diff between that tag and 2.1.2 (the version I'm using in this MR): https://github.com/flesler/jquery.scrollTo/compare/1.4.3...2.1.2 There aren't any notable breaking changes that I noticed, and I didn't see any JS errors after testing a bunch of pages. cc: @jschatz1 See merge request !4088
-
Long Nguyen authored
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into issue_15572_snippets_tab_under_user_profile
-
Connor Shea authored
Also fix one use of `gsub` that would be faster as `delete`. Use `tr` instead of `gsub` when you are replacing the same number of characters. Use `delete` instead of `gsub` when you are deleting characters.
-
Connor Shea authored
Instead the script is now included directly from the vendor directory. Resolves #17166.
-
Connor Shea authored
Also fixes the errors caused by enabling the cop. casecmp is more performant than `.downcase` and `==`.
-
- 10 May, 2016 8 commits
-
-
Jacob Schatz authored
Restore "r" shortcut Fixes "Reply with Selected Text" shortcut See merge request !4041
-
Robert Speicher authored
Add eager load paths to help prevent dependency load issues with Sidekiq workers _Originally opened at !3545 by @stanhu._ - - - Relevant resources: - https://github.com/mperham/sidekiq/wiki/FAQ#why-doesnt-sidekiq-autoload-my-rails-application-code - https://github.com/mperham/sidekiq/issues/1281#issuecomment-27129904 - http://blog.arkency.com/2014/11/dont-forget-about-eager-load-when-extending-autoload - https://github.com/rails/rails/blob/52ce6ece8c8f74064bb64e0a0b1ddd83092718e1/railties/lib/rails/engine.rb#L472-L479 - https://github.com/rails/rails/blob/v4.2.6/railties/lib/rails/paths.rb Attempts to address #3661, #11896, #12769, #13521, #14131, #14589, #14759, #14825. See merge request !3724
-
Stan Hu authored
Update Ace Editor Upgrading fixes scroll navigation on mobile. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/13987 ![scroll](/uploads/fd655fa6033ddc0337080c89c3fbf92f/scroll.gif) See merge request !3823
-
Robert Speicher authored
Fix an issue when filtering merge requests with more than one label Fixes #15529. See merge request !3886
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Jacob Schatz authored
Add to label ID to response Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/15673 See merge request !4023
-
Sean McGivern authored
`User#starred_projects` doesn't perform any visibility checks. This has a couple of problems: 1. It assumes a user can always view all of their starred projects in perpetuity (project not changed to private, access revoked, etc.). 2. It assumes that we'll only ever allow a user to star a project they can view. This is currently the case, but bugs happen. Add `User#viewable_starred_projects` to filter the starred projects by those the user either has explicit access to, or are public or internal. Then use that in all places where we list the user's starred projects.
-